Bug 103700 - When animating mask-postion on a composited layer, element renders incorrectly
Summary: When animating mask-postion on a composited layer, element renders incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-29 18:23 PST by Simon Fraser (smfr)
Modified: 2012-12-03 13:21 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.65 KB, patch)
2012-11-29 18:29 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (9.79 KB, patch)
2012-11-30 15:10 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-11-29 18:23:37 PST 
When animating mask-postion on a composited layer, element renders incorrectly
Comment 1 Simon Fraser (smfr) 2012-11-29 18:29:33 PST 
Created attachment 176881 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-29 19:58:46 PST 
Comment on attachment 176881 [details]
Patch

Attachment 176881 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15062148

New failing tests:
compositing/masks/simple-composited-mask.html
compositing/masks/masked-ancestor.html
Comment 3 Simon Fraser (smfr) 2012-11-30 15:07:57 PST 
I can't reproduce those image failures locally.
Comment 4 Simon Fraser (smfr) 2012-11-30 15:10:47 PST 
Created attachment 177033 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-30 15:12:42 PST 
Attachment 177033 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/comp..." exit_code: 1
LayoutTests/platform/chromium/TestExpectations:235:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2012-12-03 00:53:05 PST 
Comment on attachment 177033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177033&action=review

> Source/WebCore/rendering/RenderLayer.h:581
> +        DontConstrainForMask = 1 << 4,

I think I've been told to use DoNot, but it seems pretty up in the air if you search the codebase.
Comment 7 Simon Fraser (smfr) 2012-12-03 13:20:47 PST 
http://trac.webkit.org/changeset/136433
Comment 8 Simon Fraser (smfr) 2012-12-03 13:21:20 PST 
<rdar://problem/12762670>