webkitpy: autoinstaller is failing on windows
Created attachment 176879 [details] Patch
Committed r136195: <http://trac.webkit.org/changeset/136195>
Landing this unreviewed since the python win unit tests are failing, but I wouldn't mind a review anyway. I *think* this fix is correct and safe :).
still broken with these patches .. the problem is worse than I had hoped.
Created attachment 177051 [details] Patch
Given that this is my third attempt at making this work, can someone double-check my logic? I had to modify the code so that nested modules could be specified portably (as "logilab/common") but be flattened either to a safe basename (e.g. "logilab_common" for the downloaded url markers or for scratch dirs) or to a host-specific subdir (e.g. "logilab\common"). Then I had to also handle the stupid write-protected files in the archives :(.
Created attachment 177054 [details] fix ChangeLog
Comment on attachment 177054 [details] fix ChangeLog Attachment 177054 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15117027 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment on attachment 177054 [details] fix ChangeLog I would probably just not allow / to be in the target_name, but whatevs.
(In reply to comment #9) > (From update of attachment 177054 [details]) > I would probably just not allow / to be in the target_name, but whatevs. I suppose an alternative would be to have the target name use periods as separators (to mirror the python module naming) rather than forward slashes, but I imagine that would impose its own set of conversions ...
Committed r136441: <http://trac.webkit.org/changeset/136441>