Bug 103676 - Unused parameters on plugins/npapi.cpp
Summary: Unused parameters on plugins/npapi.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-29 15:18 PST by KyungTae Kim
Modified: 2012-11-29 16:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2012-11-29 15:21 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KyungTae Kim 2012-11-29 15:18:35 PST 
Because the 'instance' and 'menu' parameter are not used in NPN_PopUpContextMenu when !PLATFORM(QT) || !defined(XP_MACOSX),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter

Source/WebCore/plugins/npapi.cpp:203:9: warning: unused parameter 'instance' [-Wunused-parameter]
Source/WebCore/plugins/npapi.cpp:203:9: warning: unused parameter 'menu' [-Wunused-parameter]
Comment 1 KyungTae Kim 2012-11-29 15:21:35 PST 
Created attachment 176832 [details]
Patch
Comment 2 Kentaro Hara 2012-11-29 15:49:19 PST 
Comment on attachment 176832 [details]
Patch

OK
Comment 3 WebKit Review Bot 2012-11-29 16:49:48 PST 
Comment on attachment 176832 [details]
Patch

Clearing flags on attachment: 176832

Committed r136185: <http://trac.webkit.org/changeset/136185>
Comment 4 WebKit Review Bot 2012-11-29 16:49:51 PST 
All reviewed patches have been landed.  Closing bug.