Bug 103673 - Avoid painting lots of small rects in WebLayer painting
Summary: Avoid painting lots of small rects in WebLayer painting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-29 15:01 PST by Simon Fraser (smfr)
Modified: 2012-11-29 15:22 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.62 KB, patch)
2012-11-29 15:07 PST, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-11-29 15:01:24 PST
Avoid painting lots of small rects in WebLayer painting
Comment 1 Simon Fraser (smfr) 2012-11-29 15:07:35 PST
Created attachment 176826 [details]
Patch
Comment 2 Tim Horton 2012-11-29 15:11:02 PST
Comment on attachment 176826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176826&action=review

> Source/WebCore/platform/graphics/mac/WebLayer.mm:106
> +            const FloatRect& currRect = dirtyRects[i];

curr? :\

> Source/WebCore/platform/graphics/mac/WebLayer.mm:114
> +        layerContents->platformCALayerPaintContents(graphicsContext, enclosingIntRect(clipBounds));

Shouldn't this be the union of the rects instead?
Comment 3 Simon Fraser (smfr) 2012-11-29 15:11:25 PST
<rdar://problem/12773043>
Comment 4 Simon Fraser (smfr) 2012-11-29 15:22:42 PST
http://trac.webkit.org/changeset/136174