Bug 103662 – [V8] DOM callbacks shouldn't reimplement ScopedPersistent they should use it

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[V8] DOM callbacks shouldn't reimplement ScopedPersistent they should use it

[Adam Barth]

Created attachment 176792 [details]
Patch

[Adam Klein]

Comment on attachment 176792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176792&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3360
> +    m_callback.get().MakeWeak(this, &${v8InterfaceName}::weakCallback);

Nit, you can use operator-> here

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 176792 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176792&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3360
> > +    m_callback.get().MakeWeak(this, &${v8InterfaceName}::weakCallback);
> 
> Nit, you can use operator-> here

I need to call a function on the Handle itself, not the underlying object.  I'm pretty sure I made -> give you back the underlying object.

[Adam Barth]

In file included from gen/webkit/bindings/V8DerivedSources02.cpp:45:
gen/webcore/bindings/V8NavigatorUserMediaErrorCallback.cpp:46:17: error: no member named 'MakeWeak' in 'v8::Object'
    m_callback->MakeWeak(this, &V8NavigatorUserMediaErrorCallback::weakCallback);
    ~~~~~~~~~~  ^
In file included from gen/webkit/bindings/V8DerivedSources02.cpp:49:

[Eric Seidel (no email)]

Comment on attachment 176792 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 176792 [details]
Patch

Clearing flags on attachment: 176792

Committed r136168: <http://trac.webkit.org/changeset/136168>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.