[V8] DOM callbacks shouldn't reimplement ScopedPersistent they should use it
Created attachment 176792 [details] Patch
Comment on attachment 176792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176792&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3360 > + m_callback.get().MakeWeak(this, &${v8InterfaceName}::weakCallback); Nit, you can use operator-> here
(In reply to comment #2) > (From update of attachment 176792 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176792&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3360 > > + m_callback.get().MakeWeak(this, &${v8InterfaceName}::weakCallback); > > Nit, you can use operator-> here I need to call a function on the Handle itself, not the underlying object. I'm pretty sure I made -> give you back the underlying object.
In file included from gen/webkit/bindings/V8DerivedSources02.cpp:45: gen/webcore/bindings/V8NavigatorUserMediaErrorCallback.cpp:46:17: error: no member named 'MakeWeak' in 'v8::Object' m_callback->MakeWeak(this, &V8NavigatorUserMediaErrorCallback::weakCallback); ~~~~~~~~~~ ^ In file included from gen/webkit/bindings/V8DerivedSources02.cpp:49:
Comment on attachment 176792 [details] Patch LGTM.
Comment on attachment 176792 [details] Patch Clearing flags on attachment: 176792 Committed r136168: <http://trac.webkit.org/changeset/136168>
All reviewed patches have been landed. Closing bug.