Bug 103661 – webkitpy's run_webkit_tests should initialize the printer earlier on

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Peter Beverloo]

Before creating the Printer, which creates the MeteredStream that handles the log messages run_webkit_tests.py's run() sets up derived options. _set_up_derived_options() calls various methods on the Port objects. As this is done without a printer, they aren't able to use normal loggers and have to resort to writing to stderr directly.

There are FIXMEs in at least the Mac and Chromium-Android Ports, and the Chromium-Android Port imports "sys" for this reason alone.

[Dirk Pranke]

Created attachment 177332 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 177332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177332&action=review

FANTASTIC.

> Tools/Scripts/webkitpy/layout_tests/port/mac.py:241
> -        except ScriptError, e:
> +        except ScriptError:
>              _log.warning('Unable to sample process.')

We could log the actual error. :)

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 177332 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177332&action=review
> 
> FANTASTIC.
> 
> > Tools/Scripts/webkitpy/layout_tests/port/mac.py:241
> > -        except ScriptError, e:
> > +        except ScriptError:
> >              _log.warning('Unable to sample process.')
> 
> We could log the actual error. :)

Sure :).

[Dirk Pranke]

Committed r136443: <http://trac.webkit.org/changeset/136443>

[Peter Beverloo]

Awesome, thanks for following up!!