Bug 103649 - [BlackBerry] Cookies in private mode should not have access to public cookies
Summary: [BlackBerry] Cookies in private mode should not have access to public cookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-29 10:16 PST by otcheung
Modified: 2012-11-29 12:16 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2012-11-29 10:20 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (2.03 KB, patch)
2012-11-29 10:37 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2012-11-29 10:46 PST, otcheung 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-11-29 10:16:52 PST 
We are changing the cookie private mode behaviour so it will not have access to public cookies
Comment 1 otcheung 2012-11-29 10:20:19 PST 
Created attachment 176755 [details]
Patch
Comment 2 Rob Buis 2012-11-29 10:32:32 PST 
Comment on attachment 176755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176755&action=review

Otto agreed to clean it up some more.

> Source/WebCore/platform/blackberry/CookieManager.cpp:512
>      if (!mode) {

It would be more readable to have it called privateMode instead of mode, but your patch is not related to that.

> Source/WebCore/platform/blackberry/CookieManager.cpp:516
> +        removeAllCookies(DoNotRemoveFromBackingStore);

We always do this...
Comment 3 otcheung 2012-11-29 10:37:15 PST 
Created attachment 176758 [details]
Patch
Comment 4 otcheung 2012-11-29 10:46:43 PST 
Created attachment 176760 [details]
Patch
Comment 5 Rob Buis 2012-11-29 10:47:28 PST 
Comment on attachment 176760 [details]
Patch

LGTM.
Comment 6 WebKit Review Bot 2012-11-29 12:16:18 PST 
Comment on attachment 176760 [details]
Patch

Clearing flags on attachment: 176760

Committed r136148: <http://trac.webkit.org/changeset/136148>
Comment 7 WebKit Review Bot 2012-11-29 12:16:21 PST 
All reviewed patches have been landed.  Closing bug.