Bug 103639 - [WinCairo] Release build fix.
Summary: [WinCairo] Release build fix.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 103640 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-29 07:28 PST by peavo
Modified: 2012-12-03 08:01 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2012-11-29 07:40 PST, peavo
no flags Details | Formatted Diff | Diff
Patch (1.04 KB, patch)
2012-11-30 06:08 PST, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2012-11-29 07:28:14 PST
The method BitmapImage::notSolidColor() is exported in WebKit2CFLite.def,
but is only present when the define ASSERT_DISABLED == 0.
This causes a link error in WinCairo release builds.
Comment 1 peavo 2012-11-29 07:32:53 PST
*** Bug 103640 has been marked as a duplicate of this bug. ***
Comment 2 peavo 2012-11-29 07:40:07 PST
Created attachment 176735 [details]
Patch
Comment 3 Stephen White 2012-11-29 07:48:14 PST
Comment on attachment 176735 [details]
Patch

I don't understand why this is causing a build failure.  The only callsite I can see is inside an ASSERT.
Comment 4 peavo 2012-11-30 06:08:53 PST
Created attachment 176955 [details]
Patch
Comment 5 peavo 2012-11-30 06:12:13 PST
The symbol BitmapImage::notSolidColor() has now been removed from WebKit2.def and WebKit2CFLite.def. Adjusted the patch to avoid the ASSERT for PLATFORM(WIN).
Now, both debug and release builds should link.
Comment 6 peavo 2012-12-03 07:58:45 PST
Already fixed by r136292.
Comment 7 Stephen White 2012-12-03 08:01:11 PST
Comment on attachment 176955 [details]
Patch

Removing r?, then.