Bug 103634 - [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
Summary: [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-29 06:52 PST by Sudarsana Nagineni (babu)
Modified: 2012-11-30 01:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2012-11-29 07:14 PST, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-11-29 06:52:48 PST 
Add support for PlatformWebView::simulateRightClick() and enable WebKit2 unit test that uses it.
Comment 1 Sudarsana Nagineni (babu) 2012-11-29 07:14:24 PST 
Created attachment 176726 [details]
Patch
Comment 2 Gyuyoung Kim 2012-11-30 01:17:18 PST 
Comment on attachment 176726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176726&action=review

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:105
> +void PlatformWebView::simulateRightClick(unsigned x, unsigned y)

Don't you need to use left click as well ? In WK1, I added a button type argument to mouseClick function.

void mouseClick(int x, int y, int button = 1 /*Left*/);
Comment 3 Sudarsana Nagineni (babu) 2012-11-30 01:35:05 PST 
Comment on attachment 176726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176726&action=review

>> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:105
>> +void PlatformWebView::simulateRightClick(unsigned x, unsigned y)
> 
> Don't you need to use left click as well ? In WK1, I added a button type argument to mouseClick function.
> 
> void mouseClick(int x, int y, int button = 1 /*Left*/);

Left click is not required. API test expects only the right click.
Comment 4 WebKit Review Bot 2012-11-30 01:46:42 PST 
Comment on attachment 176726 [details]
Patch

Clearing flags on attachment: 176726

Committed r136217: <http://trac.webkit.org/changeset/136217>
Comment 5 WebKit Review Bot 2012-11-30 01:46:46 PST 
All reviewed patches have been landed.  Closing bug.