Bug 103629 – Fix the build after r136095

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Andrei Bucur]

WebKit doesn't compile due to a type error.

[Andrei Bucur]

Created attachment 176701 [details]
Patch

Comment on attachment 176701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176701&action=review

> Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm:97
> +            [NSException raise:NSInvalidArgumentException format:@"Can not encode objects of class type '%@'", static_cast<NSString *>(NSStringFromClass([m_root class]))];

that's most certainly the wrong fix. I think instead, this file should #import <Foundation/Foundation.h>

[Andrei Bucur]

(In reply to comment #2)
> (From update of attachment 176701 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176701&action=review
> 
> > Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm:97
> > +            [NSException raise:NSInvalidArgumentException format:@"Can not encode objects of class type '%@'", static_cast<NSString *>(NSStringFromClass([m_root class]))];
> 
> that's most certainly the wrong fix. I think instead, this file should #import <Foundation/Foundation.h>

Tried it and this is not the issue. You can put the NSStringFromClass return value in a NSString variable and then pass that to the formatter and it will work. I like this fix more though.

[Alexey Proskuryakov]

Comment on attachment 176701 [details]
Patch

Failing on Lion and Mountain Lion bots. I can't reproduce locally, and have no idea why this fails, but we have to get it building again.

/Volumes/Data/slave/mountainlion-debug/build/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm:97:107: error: format specifies type 'id' but the argument has type '<dependent type>' [-Werror,-Wformat]

[WebKit Review Bot]

Comment on attachment 176701 [details]
Patch

Clearing flags on attachment: 176701

Committed r136141: <http://trac.webkit.org/changeset/136141>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.