Bug 103613 – WebKit2 child processes need to initialize timer coalescing policy on Mac.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kiran Muppala]

On Mac WebKit2 processes should initialize timer coalescing policy to match those of visible applications and later update it based on UI process visibility state.

This bug is for correctly initializing the policy during process launch.

[Kiran Muppala]

Created attachment 176697 [details]
Patch: Not ready for commit until stable OS builds available.

[Kiran Muppala]

<rdar://problem/12723211>

[Mark Rowe (bdash)]

Comment on attachment 176697 [details]
Patch: Not ready for commit until stable OS builds available.



View in context: https://bugs.webkit.org/attachment.cgi?id=176697&action=review

> Source/WebKit2/Shared/mac/ChildProcessMac.mm:70
> +    // Set task_latency and task_throughput qos tiers as appropriate for a visible application.

"qos" should be written as QOS in the comment since it is an initialism.

> Source/WebKit2/Shared/mac/ChildProcessMac.mm:73
> +    struct task_qos_policy qosinfo;
> +    qosinfo.task_latency_qos_tier = LATENCY_QOS_TIER_0;
> +    qosinfo.task_throughput_qos_tier = THROUGHPUT_QOS_TIER_0;

This could be initialized on the same line as the declaration:
struct task_qos_policy qosinfo = { LATENCY_QOS_TIER_0, THROUGHPUT_QOS_TIER_0 };

[Kiran Muppala]

Created attachment 177061 [details]
Patch

[Kiran Muppala]

(In reply to comment #3)
> (From update of attachment 176697 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176697&action=review
> 
> > Source/WebKit2/Shared/mac/ChildProcessMac.mm:70
> > +    // Set task_latency and task_throughput qos tiers as appropriate for a visible application.
> 
> "qos" should be written as QOS in the comment since it is an initialism.
> 

Fixed in the comment and the ChangeLog.

> > Source/WebKit2/Shared/mac/ChildProcessMac.mm:73
> > +    struct task_qos_policy qosinfo;
> > +    qosinfo.task_latency_qos_tier = LATENCY_QOS_TIER_0;
> > +    qosinfo.task_throughput_qos_tier = THROUGHPUT_QOS_TIER_0;
> 
> This could be initialized on the same line as the declaration:
> struct task_qos_policy qosinfo = { LATENCY_QOS_TIER_0, THROUGHPUT_QOS_TIER_0 };

Thanks, this looks better.  Replaced multi statement initializer with above one line initializer.

[WebKit Review Bot]

Comment on attachment 177061 [details]
Patch

Rejecting attachment 177061 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15151613

[Kiran Muppala]

Created attachment 177814 [details]
Patch

[Kiran Muppala]

(In reply to comment #7)
> Created an attachment (id=177814) [details]
> Patch

Commit failed because the "Reviewer" line in ChangeLog read "Reviewed by NOBODY." instead of "Reviewed by NOBODY (OOPS!)."  So, fixed the reviewer line in ChangeLog.  No other changes.

[WebKit Review Bot]

Comment on attachment 177814 [details]
Patch

Clearing flags on attachment: 177814

Committed r136766: <http://trac.webkit.org/changeset/136766>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.