Bug 103612 - [Shadow] We should have a performance test of distribution for changing className.
Summary: [Shadow] We should have a performance test of distribution for changing class...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 102646
  Show dependency treegraph
 
Reported: 2012-11-29 00:52 PST by Shinya Kawanaka
Modified: 2012-12-05 22:09 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.46 KB, patch)
2012-11-29 01:19 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (4.58 KB, patch)
2012-11-29 02:41 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (4.53 KB, patch)
2012-12-05 21:39 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (4.54 KB, patch)
2012-12-05 21:43 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-29 00:52:52 PST
We would like to compare performance between (a) distributing elements using java script and (b) distributing elements using ShadowDOM.
This is a case when className is changed.
Comment 1 Shinya Kawanaka 2012-11-29 01:19:08 PST
Created attachment 176672 [details]
Patch
Comment 2 Shinya Kawanaka 2012-11-29 02:41:13 PST
Created attachment 176684 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2012-12-03 10:44:32 PST
Comment on attachment 176684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176684&action=review

> PerformanceTests/ChangeLog:12
> +        * ShadowDOM/ChangingClassNameWithoutShadow.html: Added.

ChangingClassName and ChangingClassNameShadowDOM would be better names.
Comment 4 Shinya Kawanaka 2012-12-05 21:39:22 PST
Created attachment 177927 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-12-05 21:41:50 PST
Comment on attachment 177927 [details]
Patch for landing

Rejecting attachment 177927 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/PerformanceTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15159561
Comment 6 Shinya Kawanaka 2012-12-05 21:43:49 PST
Created attachment 177928 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-12-05 22:09:17 PST
Comment on attachment 177928 [details]
Patch for landing

Clearing flags on attachment: 177928

Committed r136801: <http://trac.webkit.org/changeset/136801>
Comment 8 WebKit Review Bot 2012-12-05 22:09:20 PST
All reviewed patches have been landed.  Closing bug.