RESOLVED FIXED 103602
Convert *-appearance-pseudo-classes.html to dumpAsText tests 
https://bugs.webkit.org/show_bug.cgi?id=103602
Summary Convert *-appearance-pseudo-classes.html to dumpAsText tests
Kent Tamura
Reported 2012-11-28 22:13:11 PST
Convert *-appearance-pseudo-classes.html to dumpAsText tests
Attachments
Patch (412.03 KB, patch)
2012-11-28 22:15 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (416.63 KB, patch)
2012-11-29 00:21 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-28 22:15:46 PST
Created attachment 176649 [details] Patch
Kentaro Hara
Comment 2 2012-11-28 22:24:29 PST
Comment on attachment 176649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176649&action=review > LayoutTests/fast/forms/datetimelocal/datetimelocal-pseudo-classes.html:33 > +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")'); You might want to also check: shouldBeTrue('matchedNodesContainId(container, ":in-range", "outofrange")'); You might want to also check: document.getElementById('inrange').value = '1500-01-01T00:00'; shouldBeFalse('matchedNodesContainId(container, ":in-range", "inrange")'); shouldBeTrue('matchedNodesContainId(container, ":out-of-range", "inrange")'); > LayoutTests/fast/forms/month/month-pseudo-classes.html:33 > +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")'); Ditto. > LayoutTests/fast/forms/time/time-pseudo-classes.html:33 > +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")'); Ditto. > LayoutTests/fast/forms/week/week-pseudo-classes.html:33 > +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")'); Ditto.
Kent Tamura
Comment 3 2012-11-29 00:21:46 PST
Created attachment 176663 [details] Patch 2 Follow reviewer's comments
Kent Tamura
Comment 4 2012-11-29 00:23:43 PST
Comment on attachment 176649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176649&action=review >> LayoutTests/fast/forms/datetimelocal/datetimelocal-pseudo-classes.html:33 >> +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")'); > > You might want to also check: > > shouldBeTrue('matchedNodesContainId(container, ":in-range", "outofrange")'); > > You might want to also check: > > document.getElementById('inrange').value = '1500-01-01T00:00'; > shouldBeFalse('matchedNodesContainId(container, ":in-range", "inrange")'); > shouldBeTrue('matchedNodesContainId(container, ":out-of-range", "inrange")'); Done.
Kentaro Hara
Comment 5 2012-11-29 00:24:06 PST
Comment on attachment 176663 [details] Patch 2 Looks good.
Kent Tamura
Comment 6 2012-11-29 00:25:47 PST
Comment on attachment 176663 [details] Patch 2 Thanks!
WebKit Review Bot
Comment 7 2012-11-29 01:00:03 PST
Comment on attachment 176663 [details] Patch 2 Clearing flags on attachment: 176663 Committed r136110: <http://trac.webkit.org/changeset/136110>
WebKit Review Bot
Comment 8 2012-11-29 01:00:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.