Bug 103602 - Convert *-appearance-pseudo-classes.html to dumpAsText tests
Summary: Convert *-appearance-pseudo-classes.html to dumpAsText tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 103489
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-28 22:13 PST by Kent Tamura
Modified: 2012-11-29 01:00 PST (History)
3 users (show)

See Also:

Attachments
Patch (412.03 KB, patch)
2012-11-28 22:15 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (416.63 KB, patch)
2012-11-29 00:21 PST, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-11-28 22:13:11 PST 
Convert *-appearance-pseudo-classes.html to dumpAsText tests
Comment 1 Kent Tamura 2012-11-28 22:15:46 PST 
Created attachment 176649 [details]
Patch
Comment 2 Kentaro Hara 2012-11-28 22:24:29 PST 
Comment on attachment 176649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176649&action=review

> LayoutTests/fast/forms/datetimelocal/datetimelocal-pseudo-classes.html:33
> +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")');

You might want to also check:

  shouldBeTrue('matchedNodesContainId(container, ":in-range", "outofrange")');

You might want to also check:

  document.getElementById('inrange').value = '1500-01-01T00:00';
  shouldBeFalse('matchedNodesContainId(container, ":in-range", "inrange")');
  shouldBeTrue('matchedNodesContainId(container, ":out-of-range", "inrange")');

> LayoutTests/fast/forms/month/month-pseudo-classes.html:33
> +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")');

Ditto.

> LayoutTests/fast/forms/time/time-pseudo-classes.html:33
> +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")');

Ditto.

> LayoutTests/fast/forms/week/week-pseudo-classes.html:33
> +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")');

Ditto.
Comment 3 Kent Tamura 2012-11-29 00:21:46 PST 
Created attachment 176663 [details]
Patch 2

Follow reviewer's comments
Comment 4 Kent Tamura 2012-11-29 00:23:43 PST 
Comment on attachment 176649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176649&action=review

>> LayoutTests/fast/forms/datetimelocal/datetimelocal-pseudo-classes.html:33
>> +shouldBeFalse('matchedNodesContainId(container, ":out-of-range", "outofrange")');
> 
> You might want to also check:
> 
>   shouldBeTrue('matchedNodesContainId(container, ":in-range", "outofrange")');
> 
> You might want to also check:
> 
>   document.getElementById('inrange').value = '1500-01-01T00:00';
>   shouldBeFalse('matchedNodesContainId(container, ":in-range", "inrange")');
>   shouldBeTrue('matchedNodesContainId(container, ":out-of-range", "inrange")');

Done.
Comment 5 Kentaro Hara 2012-11-29 00:24:06 PST 
Comment on attachment 176663 [details]
Patch 2

Looks good.
Comment 6 Kent Tamura 2012-11-29 00:25:47 PST 
Comment on attachment 176663 [details]
Patch 2

Thanks!
Comment 7 WebKit Review Bot 2012-11-29 01:00:03 PST 
Comment on attachment 176663 [details]
Patch 2

Clearing flags on attachment: 176663

Committed r136110: <http://trac.webkit.org/changeset/136110>
Comment 8 WebKit Review Bot 2012-11-29 01:00:06 PST 
All reviewed patches have been landed.  Closing bug.