RESOLVED FIXED 103588
Change Bytecompiler s_dumpsGeneratedCode to an Options value 
https://bugs.webkit.org/show_bug.cgi?id=103588
Summary Change Bytecompiler s_dumpsGeneratedCode to an Options value
Michael Saboff
Reported 2012-11-28 18:33:29 PST
The diagnostic dumping of bytecodes at compile time is controlled bu the static s_dumpsGeneratedCode in BytecodeGenerator.cpp. It has a setter and getter. This should all be changed to use the Options class to be consistent with other similar optional behavior.
Attachments
Patch (4.17 KB, patch)
2012-11-28 18:36 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-11-28 18:36:17 PST
Created attachment 176624 [details] Patch
WebKit Review Bot
Comment 2 2012-11-28 19:16:59 PST
Comment on attachment 176624 [details] Patch Clearing flags on attachment: 176624 Committed r136086: <http://trac.webkit.org/changeset/136086>
WebKit Review Bot
Comment 3 2012-11-28 19:17:02 PST
All reviewed patches have been landed. Closing bug.
Michael Saboff
Comment 5 2012-11-29 10:23:57 PST
(In reply to comment #4) > I think this broke Windows: http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/58714/steps/compile-webkit/logs/stdio Landed speculative build fix in r136140 <http://trac.webkit.org/changeset/136140>.
Note You need to log in before you can comment on or make changes to this bug.