Bug 103588 - Change Bytecompiler s_dumpsGeneratedCode to an Options value
Summary: Change Bytecompiler s_dumpsGeneratedCode to an Options value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 18:33 PST by Michael Saboff
Modified: 2012-11-29 10:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2012-11-28 18:36 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-11-28 18:33:29 PST 
The diagnostic  dumping of bytecodes at compile time is controlled bu the static s_dumpsGeneratedCode in BytecodeGenerator.cpp.  It has a setter and getter.  This should all be changed to use the Options class to be consistent with other similar optional behavior.
Comment 1 Michael Saboff 2012-11-28 18:36:17 PST 
Created attachment 176624 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-28 19:16:59 PST 
Comment on attachment 176624 [details]
Patch

Clearing flags on attachment: 176624

Committed r136086: <http://trac.webkit.org/changeset/136086>
Comment 3 WebKit Review Bot 2012-11-28 19:17:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Michael Saboff 2012-11-29 10:23:57 PST 
(In reply to comment #4)
> I think this broke Windows: http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/58714/steps/compile-webkit/logs/stdio

Landed speculative build fix in r136140 <http://trac.webkit.org/changeset/136140>.