Bug 103585 - run-perf-tests --chromium-android fails due to Skia INFO logging
Summary: run-perf-tests --chromium-android fails due to Skia INFO logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 17:44 PST by Eric Seidel (no email)
Modified: 2012-11-29 08:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2012-11-28 23:41 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-11-28 17:44:45 PST 
run-perf-tests --chromium-android fails due to Skia INFO logging
Comment 1 Eric Seidel (no email) 2012-11-28 17:46:21 PST 
[INFO:SkFontHost_android.cpp(1158)] Use Test Config File Main /data/local/tmp/drt/android_main_fonts.xml, Fallback /data/local/tmp/drt/android_fallback_fonts.xml, Font Dir /data/local/tmp/drt/fonts/

is the log which was causing the failure.
Comment 2 Ryosuke Niwa 2012-11-28 17:54:47 PST 
We can add a regex to _lines_to_ignore_in_stderr to ignore this.
Comment 3 Adam Barth 2012-11-28 18:19:07 PST 
Yeah, I showed him how we handled the other cases.  I think he's got a patch locally.
Comment 4 Eric Seidel (no email) 2012-11-28 22:57:16 PST 
Oh, I thought I uploaded this.  I think I may have reverted the patch.  I'll just re-write it.
Comment 5 Eric Seidel (no email) 2012-11-28 23:41:23 PST 
Created attachment 176658 [details]
Patch
Comment 6 Adam Barth 2012-11-29 08:45:47 PST 
Comment on attachment 176658 [details]
Patch

rniwa didn't want us to skip all the WARNINGs, but skipping all the INFOs seems fine.
Comment 7 WebKit Review Bot 2012-11-29 08:51:36 PST 
Comment on attachment 176658 [details]
Patch

Clearing flags on attachment: 176658

Committed r136134: <http://trac.webkit.org/changeset/136134>
Comment 8 WebKit Review Bot 2012-11-29 08:51:39 PST 
All reviewed patches have been landed.  Closing bug.