RESOLVED FIXED 103584
SpeculatedType dumping should not use the static char buffer[thingy] idiom 
https://bugs.webkit.org/show_bug.cgi?id=103584
Summary SpeculatedType dumping should not use the static char buffer[thingy] idiom
Filip Pizlo
Reported 2012-11-28 17:43:08 PST
Instead it should have an appropriate dump(PrintStream&) method.
Attachments
the patch (41.43 KB, patch)
2012-11-28 18:02 PST, Filip Pizlo 		msaboff: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
patch for landing (46.02 KB, patch)
2012-11-28 18:34 PST, Filip Pizlo 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
patch for landing (46.12 KB, patch)
2012-11-28 20:27 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-28 18:02:16 PST
Created attachment 176619 [details] the patch I still need to play with the other build systems, but other than that it's ready to review.
Early Warning System Bot
Comment 2 2012-11-28 18:11:07 PST
Comment on attachment 176619 [details] the patch Attachment 176619 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15010732
Early Warning System Bot
Comment 3 2012-11-28 18:13:38 PST
Comment on attachment 176619 [details] the patch Attachment 176619 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15015675
Michael Saboff
Comment 4 2012-11-28 18:20:11 PST
Comment on attachment 176619 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=176619&action=review r+. Please update the change logs removing the extraneous namespace entries. > Source/JavaScriptCore/ChangeLog:18 > + (JSC): Remove the (JSC): only lines that the tools shouldn't put in. > Source/JavaScriptCore/ChangeLog:26 > + (WTF): Same here. > Source/JavaScriptCore/ChangeLog:34 > + (DFG): Ditto. > Source/WTF/ChangeLog:13 > + (WTF): Ditto.
Filip Pizlo
Comment 5 2012-11-28 18:34:52 PST
Created attachment 176623 [details] patch for landing I will wait for EWS to land because I'm worried about vsnprintf and va_copy not being available on some platforms.
Early Warning System Bot
Comment 6 2012-11-28 18:49:14 PST
Comment on attachment 176623 [details] patch for landing Attachment 176623 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15044095
Early Warning System Bot
Comment 7 2012-11-28 18:51:26 PST
Comment on attachment 176623 [details] patch for landing Attachment 176623 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15029586
WebKit Review Bot
Comment 8 2012-11-28 18:53:46 PST
Comment on attachment 176623 [details] patch for landing Attachment 176623 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15023643
Build Bot
Comment 9 2012-11-28 19:26:52 PST
Comment on attachment 176623 [details] patch for landing Attachment 176623 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15018673
Filip Pizlo
Comment 10 2012-11-28 20:27:53 PST
Created attachment 176632 [details] patch for landing Trying again
Filip Pizlo
Comment 11 2012-11-28 22:03:02 PST
Landed in http://trac.webkit.org/changeset/136096
Note You need to log in before you can comment on or make changes to this bug.