Bug 103579 - Positioned replaced elements should resolve vertical margins against their containing block's logical width
Summary: Positioned replaced elements should resolve vertical margins against their co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 103246
  Show dependency tree / graph
 
Reported: 2012-11-28 17:01 PST by Bear Travis
Modified: 2012-12-13 18:14 PST (History)
5 users (show)

See Also:

Attachments
Initial patch (8.20 KB, patch)
2012-11-29 17:36 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Updated patch (10.90 KB, patch)
2012-11-29 17:39 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Updating tests (16.26 KB, patch)
2012-11-29 18:02 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Updating changelogs & tests (14.42 KB, patch)
2012-12-04 12:42 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Converting to static html content (14.29 KB, patch)
2012-12-13 17:19 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-11-28 17:01:13 PST 
They currently use the element's block-direction measurement of the containing block.
Comment 1 Bear Travis 2012-11-29 17:36:37 PST 
Created attachment 176861 [details]
Initial patch

First pass at a patch, using the containing block's logical width to resolve all percentage margins.
Comment 2 Bear Travis 2012-11-29 17:39:16 PST 
Created attachment 176863 [details]
Updated patch

Uploading a newer version of the patch, with changelogs and tests.
Comment 3 Bear Travis 2012-11-29 18:02:10 PST 
Created attachment 176871 [details]
Updating tests
Comment 4 Bear Travis 2012-12-04 12:42:14 PST 
Created attachment 177529 [details]
Updating changelogs & tests
Comment 5 Bear Travis 2012-12-13 17:19:36 PST 
Created attachment 179384 [details]
Converting to static html content

Creating the containers and elements with HTML markup rather than Javascript to make the test easier to read.
Comment 6 Emil A Eklund 2012-12-13 17:47:30 PST 
Comment on attachment 179384 [details]
Converting to static html content

Thanks for making the test changes I suggested. Looks good.
Comment 7 WebKit Review Bot 2012-12-13 18:14:35 PST 
Comment on attachment 179384 [details]
Converting to static html content

Clearing flags on attachment: 179384

Committed r137695: <http://trac.webkit.org/changeset/137695>
Comment 8 WebKit Review Bot 2012-12-13 18:14:39 PST 
All reviewed patches have been landed.  Closing bug.