Bug 103576 – Absolutely positioned non-replaced elements should resolve vertical margins against their containing block's logical width

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bear Travis]

http://www.w3.org/TR/CSS2/box.html#margin-properties
http://dev.w3.org/csswg/css3-writing-modes/#dimension-mapping

This will need to be fixed for replaced elements as well.

[Bear Travis]

Created attachment 176822 [details]
Initial patch

Includes some updates to line indentation to make the style checker happy

[Bear Travis]

Created attachment 177342 [details]
Simplifying patch

Rewording the changelog to be more descriptive, minimizing the patch footprint, and moving to js-style tests.

[Early Warning System Bot]

Comment on attachment 177342 [details]
Simplifying patch

Attachment 177342 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15097737

[Early Warning System Bot]

Comment on attachment 177342 [details]
Simplifying patch

Attachment 177342 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15104692

[Bear Travis]

Created attachment 177357 [details]
Fixing build

[WebKit Review Bot]

Comment on attachment 177357 [details]
Fixing build

Rejecting attachment 177357 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   8b8f204..9cffc45  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at 9cffc451c10239895188285fa8cdb2dbd36f385d but expected 8b8f204b56b60ddd016afb9099b92163ce73004b
 ! 8b8f204..9cffc45  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15157006

[WebKit Review Bot]

Comment on attachment 177357 [details]
Fixing build

Rejecting attachment 177357 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   a0bd058..e9d9059  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at e9d90592d3ba8ebe3e8a5ae811eea04f2940e996 but expected a0bd0584a2eb25a8bb88b2de129e3453f2ab97d7
 ! a0bd058..e9d9059  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15120956

[WebKit Review Bot]

Comment on attachment 177357 [details]
Fixing build

Rejecting attachment 177357 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   4c9966d..c0a4c3a  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at c0a4c3a40ce96884ae4c1472ef9d4edf6af9b111 but expected 4c9966dabd73e7df4d0cfc1858ece45aeb05b888
 ! 4c9966d..c0a4c3a  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15160028

[Eric Seidel (no email)]

Comment on attachment 177357 [details]
Fixing build

I believe abarth has fixed the cq for now.

[WebKit Review Bot]

Comment on attachment 177357 [details]
Fixing build

Clearing flags on attachment: 177357

Committed r136646: <http://trac.webkit.org/changeset/136646>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.