Bug 103568 - [mac] WebHTMLConverter should maintain font size even when there is no related NSFont
Summary: [mac] WebHTMLConverter should maintain font size even when there is no relate...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks: 103496
  Show dependency tree / graph
 
Reported: 2012-11-28 15:42 PST by Tim Horton
Modified: 2012-11-28 16:15 PST (History)
4 users (show)

See Also:

Attachments
patch (2.27 KB, patch)
2012-11-28 15:44 PST, Tim Horton 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-11-28 15:42:22 PST 
If WebHTMLConverter is faced with a Web font within a range in editingAttributedStringFromRange, it drops the style on the floor. It should instead substitute a default font of the appropriate size.
Comment 1 Tim Horton 2012-11-28 15:44:33 PST 
Created attachment 176592 [details]
patch

Looking into how to test, but it seems potentially quite tricky.
Comment 2 Alexey Proskuryakov 2012-11-28 15:55:48 PST 
Comment on attachment 176592 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176592&action=review

> Source/WebCore/ChangeLog:12
> +        (+[WebHTMLConverter editingAttributedStringFromRange:]):

Do we have the same issue in non-editing version?
Comment 3 Tim Horton 2012-11-28 16:07:10 PST 
(In reply to comment #2)
> (From update of attachment 176592 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176592&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        (+[WebHTMLConverter editingAttributedStringFromRange:]):
> 
> Do we have the same issue in non-editing version?

From code inspection it looks to me like the non-editing path does the right thing, actually!
Comment 4 Tim Horton 2012-11-28 16:15:42 PST 
http://trac.webkit.org/changeset/136073