Bug 103560 - [BlackBerry] CookieJarBlackBerry will use document settings for cookiesEnabled
Summary: [BlackBerry] CookieJarBlackBerry will use document settings for cookiesEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 13:51 PST by otcheung
Modified: 2012-11-28 14:37 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.76 KB, patch)
2012-11-28 14:02 PST, otcheung
no flags Details | Formatted Diff | Diff
Patch (3.80 KB, patch)
2012-11-28 14:07 PST, otcheung
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-11-28 13:51:37 PST
Syncing up platform cookie settings with document settings. CookieJar will now use document settings only.
Comment 1 otcheung 2012-11-28 14:02:23 PST
Created attachment 176572 [details]
Patch
Comment 2 otcheung 2012-11-28 14:07:35 PST
Created attachment 176573 [details]
Patch
Comment 3 Rob Buis 2012-11-28 14:08:59 PST
Comment on attachment 176573 [details]
Patch

LGTM.
Comment 4 kov's GTK+ EWS bot 2012-11-28 14:26:53 PST
Comment on attachment 176573 [details]
Patch

Attachment 176573 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15028566
Comment 5 WebKit Review Bot 2012-11-28 14:31:32 PST
Comment on attachment 176573 [details]
Patch

Rejecting attachment 176573 [details] from commit-queue.

otcheung@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 WebKit Review Bot 2012-11-28 14:37:54 PST
Comment on attachment 176573 [details]
Patch

Clearing flags on attachment: 176573

Committed r136058: <http://trac.webkit.org/changeset/136058>
Comment 7 WebKit Review Bot 2012-11-28 14:37:58 PST
All reviewed patches have been landed.  Closing bug.