Bug 103558 - Allow clients to ask for the WebView/WKView placeholder view when in full screen mode.
Summary: Allow clients to ask for the WebView/WKView placeholder view when in full scr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 13:33 PST by Jer Noble
Modified: 2013-01-29 15:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (6.93 KB, patch)
2012-11-28 13:40 PST, Jer Noble 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-11-28 13:33:53 PST 
Add SPI to allow clients to ask for a WebView/WKView placeholder view in full scren.
Comment 1 Jer Noble 2012-11-28 13:40:39 PST 
Created attachment 176563 [details]
Patch
Comment 2 Benjamin Poulain 2013-01-29 12:22:03 PST 
Comment on attachment 176563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176563&action=review

This is very unfortunate, but I don't see a cleaner solution, especially for WebKit1. :(

For WebKit2, IMHO, we should keep the same NSView in place, and use a new view to present the content in fullscreen. Since the WebKit layer is disconnected from the NSView, we can theoretically move the backend to a new view.

> Source/WebKit/mac/ChangeLog:4
> +        Allow clients to ask for the WebView/WKView placeholder view when in full screen mode.
> +        https://bugs.webkit.org/show_bug.cgi?id=103558

It would be good to provide the radar number in the ChangeLog for future reference. This radar is pretty good.
Comment 3 Jer Noble 2013-01-29 15:56:36 PST 
Committed r141173: <http://trac.webkit.org/changeset/141173>