Bug 103551 - [chromium] make sourceDevice available to more WebGestureEvent subtypes
Summary: [chromium] make sourceDevice available to more WebGestureEvent subtypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 12:38 PST by Robert Kroeger
Modified: 2012-12-02 02:43 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2012-11-28 12:52 PST, Robert Kroeger
no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2012-11-30 08:15 PST, Robert Kroeger
no flags Details | Formatted Diff | Diff
Patch (2.12 KB, patch)
2012-11-30 09:47 PST, Robert Kroeger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-11-28 12:38:14 PST
Chrome sends gesture events from both the touchpad and the touchscreen. In particular: GestureScrollBegin, GestureScrollEnd, GestureFlingStart and GestureFlingCancel can all be sent from both devices. Currently, only GestureFlingStart sub-types are tagged with their device source. But it is also necessary to know the source device for the remaining three sub-types. Add a new payload for these sub-types.
Comment 1 Robert Kroeger 2012-11-28 12:52:52 PST
Created attachment 176554 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-28 12:58:53 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Alexandre Elias 2012-11-28 13:01:43 PST
Should we just add it outside the union?  The property could be useful for other event types as well (ScrollUpdate, pinch, etc).
Comment 4 James Robinson 2012-11-28 13:09:29 PST
(In reply to comment #3)
> Should we just add it outside the union?  The property could be useful for other event types as well (ScrollUpdate, pinch, etc).

I like this idea.
Comment 5 Robert Kroeger 2012-11-30 08:15:56 PST
Created attachment 176972 [details]
Patch
Comment 6 Robert Kroeger 2012-11-30 08:17:07 PST
Comment on attachment 176972 [details]
Patch

Sounds good to me.

This is step one of having the flag be for all WebGestureEvent instances. Please take a look.
Comment 7 WebKit Review Bot 2012-11-30 08:46:03 PST
Comment on attachment 176972 [details]
Patch

Attachment 176972 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15062385
Comment 8 Robert Kroeger 2012-11-30 09:47:22 PST
Created attachment 176983 [details]
Patch
Comment 9 Alexandre Elias 2012-11-30 11:17:07 PST
LGTM
Comment 10 WebKit Review Bot 2012-12-02 02:43:11 PST
Comment on attachment 176983 [details]
Patch

Clearing flags on attachment: 176983

Committed r136325: <http://trac.webkit.org/changeset/136325>
Comment 11 WebKit Review Bot 2012-12-02 02:43:14 PST
All reviewed patches have been landed.  Closing bug.