Bug 103550 - Web Inspector: Make main-thread monitoring go through InspectorController
Summary: Web Inspector: Make main-thread monitoring go through InspectorController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on: 103695
Blocks: 103120
  Show dependency treegraph
 
Reported: 2012-11-28 12:26 PST by Eugene Klyuchnikov
Modified: 2012-12-03 12:05 PST (History)
11 users (show)

See Also:


Attachments
Patch (15.07 KB, patch)
2012-11-29 10:55 PST, Eugene Klyuchnikov
no flags Details | Formatted Diff | Diff
Patch (15.46 KB, patch)
2012-11-30 12:09 PST, Eugene Klyuchnikov
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2012-11-28 12:26:12 PST
Actually InspectorInstrumentation itself filters instrumentation calls.
Comment 1 Eugene Klyuchnikov 2012-11-29 10:55:41 PST
Created attachment 176761 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-29 10:57:54 PST
Attachment 176761 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/chromium/src/InspectorClientImpl.h:46:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-11-29 15:08:15 PST
Comment on attachment 176761 [details]
Patch

Clearing flags on attachment: 176761

Committed r136171: <http://trac.webkit.org/changeset/136171>
Comment 4 WebKit Review Bot 2012-11-29 15:08:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2012-11-29 17:38:32 PST
Re-opened since this is blocked by bug 103695
Comment 6 Eugene Klyuchnikov 2012-11-30 12:09:20 PST
Created attachment 177004 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-30 12:12:25 PST
Attachment 177004 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/chromium/src/InspectorClientImpl.h:46:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Review Bot 2012-12-03 11:09:10 PST
Comment on attachment 177004 [details]
Patch

Rejecting attachment 177004 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   1db1bee..cce9e2a  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at cce9e2ab4c4544da56392b8fc08797434f12b9b3 but expected 1db1bee680414c2b5d10e6b820eb7c7e89858e47
 ! 1db1bee..cce9e2a  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15100609
Comment 9 Andrey Kosyakov 2012-12-03 12:05:05 PST
Committed r136426: <http://trac.webkit.org/changeset/136426>