Bug 103546 - Report CSS as initiator instead of elements, except body
Summary: Report CSS as initiator instead of elements, except body
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Simonsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 12:01 PST by James Simonsen
Modified: 2012-11-30 11:20 PST (History)
10 users (show)

See Also:

Attachments
Patch (7.22 KB, patch)
2012-11-28 12:06 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Patch (9.30 KB, patch)
2012-11-29 15:42 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Simonsen 2012-11-28 12:01:22 PST 
Report CSS as initiator instead of elements, except body
Comment 1 James Simonsen 2012-11-28 12:06:58 PST 
Created attachment 176537 [details]
Patch
Comment 2 James Simonsen 2012-11-28 12:08:01 PST 
I checked with Marja over e-mail. It sounds like this is okay, but I wanted to double check before we land this.
Comment 3 WebKit Review Bot 2012-11-28 13:56:50 PST 
Comment on attachment 176537 [details]
Patch

Attachment 176537 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15026560

New failing tests:
platform/chromium/fast/loader/resource-request-callbacks.html
Comment 4 Marja Hölttä 2012-11-29 00:38:35 PST 
Yup, afaics this makes sense for our use case (notifying the embedder when resources are requested) too. E.g., for CSS initiating image loads, we'd anyway need to do something to all elements which would get the image from the CSS, and making one of those elements the initiator doesn't help.

(The test needs to be updated though, but it's ok.)
Comment 5 James Simonsen 2012-11-29 15:42:57 PST 
Created attachment 176836 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-30 11:20:37 PST 
Comment on attachment 176836 [details]
Patch

Clearing flags on attachment: 176836

Committed r136256: <http://trac.webkit.org/changeset/136256>
Comment 7 WebKit Review Bot 2012-11-30 11:20:42 PST 
All reviewed patches have been landed.  Closing bug.