Bug 103545 - Web Inspector: introduce fast case for within-chunk edit
Summary: Web Inspector: introduce fast case for within-chunk edit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on: 103762
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-28 12:00 PST by Pavel Feldman
Modified: 2012-11-30 13:55 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.04 KB, patch)
2012-11-28 13:59 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-11-28 12:00:47 PST 
Otherwise we rebuild entire chunk upon any input event.
Comment 1 Pavel Feldman 2012-11-28 13:59:32 PST 
Created attachment 176570 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-11-29 10:24:30 PST 
Comment on attachment 176570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176570&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2424
> +            var lastUndamagedLineRow = lastDamagedChunk.expandedLineRow(oldRange.startLine - 1);

s/lastDamagedChunk/firstDamagedChunk/ for consistency

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2434
> +            firstDamagedChunk.updateCollapsedLineRow();

This could be done lazily, do you intend change that later?
Comment 3 Pavel Feldman 2012-11-29 11:34:38 PST 
> This could be done lazily, do you intend change that later?

Yep
Comment 4 WebKit Review Bot 2012-11-29 12:07:28 PST 
Comment on attachment 176570 [details]
Patch

Clearing flags on attachment: 176570

Committed r136145: <http://trac.webkit.org/changeset/136145>
Comment 5 WebKit Review Bot 2012-11-29 12:07:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-11-30 12:26:24 PST 
Re-opened since this is blocked by bug 103762