UNCONFIRMED 103525
Handling of png decoded rows can be improved. 
https://bugs.webkit.org/show_bug.cgi?id=103525
Summary Handling of png decoded rows can be improved.
Anton Obzhirov
Reported 2012-11-28 07:21:04 PST
I've made few optimizations to handle decoded rows after pnglib: 1) Replace divides with shifts for premultiplied alpha calculation 2) Do early exit for non trivial alpha checking. 3) Remove few branch statements from the loop. As result about 10-20% speed improvement for PNG images decoding time.
Attachments
Patch (6.16 KB, patch)
2012-11-28 07:24 PST, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Patch (6.37 KB, patch)
2012-11-28 08:49 PST, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Patch (6.37 KB, patch)
2012-12-03 03:55 PST, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anton Obzhirov
Comment 1 2012-11-28 07:24:16 PST
Created attachment 176482 [details] Patch
WebKit Review Bot
Comment 2 2012-11-28 07:28:31 PST
Comment on attachment 176482 [details] Patch Attachment 176482 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15016429
Peter Beverloo (cr-android ews)
Comment 3 2012-11-28 08:27:01 PST
Comment on attachment 176482 [details] Patch Attachment 176482 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15003884
Anton Obzhirov
Comment 4 2012-11-28 08:49:01 PST
Created attachment 176493 [details] Patch
Anton Obzhirov
Comment 5 2012-11-28 09:42:42 PST
Need extra time to figure out why there are some tests failing for cr-linux, cr-android. Will submit update after that.
WebKit Review Bot
Comment 6 2012-11-28 14:43:00 PST
Comment on attachment 176493 [details] Patch Attachment 176493 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15029520 New failing tests: http/tests/misc/acid2-pixel.html fast/borders/border-fit.html compositing/video/video-controls-layer-creation.html fast/backgrounds/border-radius-split-background-image.html compositing/nested-direct-image-compositing.html compositing/direct-image-compositing.html http/tests/images/png-partial-load.html fast/backgrounds/size/contain-and-cover-zoomed.html css2.1/t0905-c414-flt-fit-01-d-g.html animations/suspend-resume-animation-events.html canvas/philip/tests/toDataURL.png.complexcolours.html http/tests/images/png-progressive-load.html fast/css/acid2-pixel.html fast/block/positioning/replaced-inside-fixed-top-bottom.html fast/css/input-search-padding.html fast/canvas/toDataURL-alpha.html editing/pasteboard/data-transfer-items-image-png.html fast/backgrounds/bgCompositeCopy.html css2.1/t0905-c5525-flthw-00-c-g.html css2.1/20110323/replaced-intrinsic-003.htm compositing/visibility/visibility-image-layers.html compositing/overflow/scrollbar-painting.html animations/cross-fade-border-image-source.html fast/backgrounds/size/contain-and-cover.html css2.1/t0801-c412-hz-box-00-b-a.html fast/backgrounds/background-position-parsing.html fast/canvas/canvas-toDataURL-webp.html compositing/masks/direct-image-mask.html css2.1/t0905-c5526-flthw-00-c-g.html compositing/reflections/simple-composited-reflections.html
Anton Obzhirov
Comment 7 2012-12-03 03:55:25 PST
Created attachment 177226 [details] Patch
Anders Carlsson
Comment 8 2014-02-05 11:03:07 PST
Comment on attachment 177226 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.