Bug 103522 – Coordinated Graphics: Images disappear randomly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Kalyan]

Steps to reproduce:

Load the page http://media.24ways.org/2009/14/5/index.html in MiniBrowser
Hover the mouse on any image.

Expected result:
The image is zoomed in

Actual Result:
Rest of the images seem to disappear randomly.
If the mouse is moved away from the image, all the images re-appear.


Seems to work fine with Firefox and Chrome browser.

[Kalyan]

(In reply to comment #0)
> Steps to reproduce:
> 
> Load the page http://media.24ways.org/2009/14/5/index.html in MiniBrowser
> Hover the mouse on any image.
> 
> Expected result:
> The image is zoomed in
> 
> Actual Result:
> Rest of the images seem to disappear randomly.
> If the mouse is moved away from the image, all the images re-appear.
> 
> 
> Seems to work fine with Firefox and Chrome browser.

Images also re-appear automatically after the zoom animation has finished.

[Kalyan]

(In reply to comment #1)
> (In reply to comment #0)
> > Steps to reproduce:
> > 
> > Load the page http://media.24ways.org/2009/14/5/index.html in MiniBrowser
> > Hover the mouse on any image.
> > 
> > Expected result:
> > The image is zoomed in
> > 
> > Actual Result:
> > Rest of the images seem to disappear randomly.
> > If the mouse is moved away from the image, all the images re-appear.
> > 
> > 
> > Seems to work fine with Firefox and Chrome browser.
> 
> Images also re-appear automatically after the zoom animation has finished.

Same behaviour on Qt-MiniBrowser

[Kenneth Rohde Christiansen]

Noam says that it might be related to the direct image compositing.

[Noam Rosenthal]

(In reply to comment #3)
> Noam says that it might be related to the direct image compositing.

Easy way to find out: always return false from CoordinatedGraphicsLayer::shouldDirectlyCompositeImage.

[Dongseong Hwang]

(In reply to comment #4)
> (In reply to comment #3)
> > Noam says that it might be related to the direct image compositing.
> 
> Easy way to find out: always return false from CoordinatedGraphicsLayer::shouldDirectlyCompositeImage.

We still have flash after making CoordinatedGraphicsLayer::shouldDirectlyCompositeImage return false.

However, we cannot reproduce in WK1. I think it is problem in coordinated graphics.

[Dongseong Hwang]

Created attachment 176597 [details]
Not for review: Patch to help understanding.

not for review: this patch helps us understand what is problem

[Dongseong Hwang]

(In reply to comment #6)
> Created an attachment (id=176597) [details]
> Patch
> 
> not for review: this patch helps us understand what is problem

If applying this patch, this bug is fixed. Bug I think we can find better solution.

[Dongseong Hwang]

I made it. After layout test, I'll post!

[Dongseong Hwang]

Created attachment 177097 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 177097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177097&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:97
>  {
>      dispatchUpdate(bind(&LayerTreeRenderer::deleteLayer, m_renderer.get(), id));
> -    updateViewport();
>  }

why is this change not explained in thechangelog

[Dongseong Hwang]

Created attachment 177098 [details]
Patch

[Dongseong Hwang]

Comment on attachment 177097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177097&action=review

>> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:97
>>  }
> 
> why is this change not explained in thechangelog

It's mistake. I explain in next patch!

[WebKit Review Bot]

Comment on attachment 177098 [details]
Patch

Clearing flags on attachment: 177098

Committed r136341: <http://trac.webkit.org/changeset/136341>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.