Bug 103508 - [EFL][WK2] input-with-validation-without-shadow.html makes following tests crash after r135935
Summary: [EFL][WK2] input-with-validation-without-shadow.html makes following tests cr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yael
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 05:24 PST by Jussi Kukkonen (jku)
Modified: 2012-11-28 21:03 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2012-11-28 18:08 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Kukkonen (jku) 2012-11-28 05:24:40 PST
The patch in bug 102833 seems to have started to "crash" fast/dom/shadow/input-with-validation.html (really PROCESS UNRESPONSIVE).

It won't do it alone but e.g. running these tests will make the last one fail with "webprocess crashed"
 fast/dom/shadow/input-with-validation-without-shadow.html failed
 fast/dom/shadow/input-with-validation.html failed unexpectedly
Comment 1 Yael 2012-11-28 05:48:56 PST
We also have these bugs to track the crash:
https://bugs.webkit.org/show_bug.cgi?id=98026
https://bugs.webkit.org/show_bug.cgi?id=99886
Comment 2 Yael 2012-11-28 06:44:20 PST
My first observation is that removing fast/dom/shadow/input-with-validation.html from the run list causes insertion-point-list-menu-crash.html to timeout, but removing input-with-validation-without-shadow.html from the list results in all the tests passing.
Comment 3 Jussi Kukkonen (jku) 2012-11-28 07:22:33 PST
(In reply to comment #1)
> We also have these bugs to track the crash:
> https://bugs.webkit.org/show_bug.cgi?id=98026
> https://bugs.webkit.org/show_bug.cgi?id=99886

These have different symptoms. I don't see why they'd be the same bug.

(In reply to comment #2)
> My first observation is that removing fast/dom/shadow/input-with-validation.html from the run list causes insertion-point-list-menu-crash.html to timeout, but removing input-with-validation-without-shadow.html from the list results in all the tests passing.

Well, I'll skip input-with-validation-without-shadow.html for now then. Can't keep the bot red all day.
Comment 4 Yael 2012-11-28 15:24:41 PST
When we run the test input-with-validation-without-shadow.html, we load immediately after that the ref test input-with-validation-without-shadow-expected.html .
The test sends a click event to the form control to submit it. At this point we start page transition and lock the tree. The page transition never finishes. When we try to dump the pixels for the test, the tree is locked.
It becomes unlocked only after the timeout expires and we load about:blank.
Comment 5 Yael 2012-11-28 18:08:46 PST
Created attachment 176620 [details]
Patch

Avoid submitting the ref test's form as discussed on iRC.
Comment 6 Shinya Kawanaka 2012-11-28 20:58:49 PST
Hi,

I'm the person who wrote the test. I'm sorry that my wrong test has bothered you.
Right, submit() should not be called in input-with-validation-without-shadow-expected.html .
Thank you for fixing it!
Comment 7 Kent Tamura 2012-11-28 20:59:37 PST
Comment on attachment 176620 [details]
Patch

ok
Comment 8 WebKit Review Bot 2012-11-28 21:03:18 PST
Comment on attachment 176620 [details]
Patch

Clearing flags on attachment: 176620

Committed r136088: <http://trac.webkit.org/changeset/136088>
Comment 9 WebKit Review Bot 2012-11-28 21:03:23 PST
All reviewed patches have been landed.  Closing bug.