Bug 103508 – [EFL][WK2] input-with-validation-without-shadow.html makes following tests crash after r135935

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jussi Kukkonen (jku)]

The patch in bug 102833 seems to have started to "crash" fast/dom/shadow/input-with-validation.html (really PROCESS UNRESPONSIVE).

It won't do it alone but e.g. running these tests will make the last one fail with "webprocess crashed"
 fast/dom/shadow/input-with-validation-without-shadow.html failed
 fast/dom/shadow/input-with-validation.html failed unexpectedly

[Yael]

We also have these bugs to track the crash:
https://bugs.webkit.org/show_bug.cgi?id=98026
https://bugs.webkit.org/show_bug.cgi?id=99886

[Yael]

My first observation is that removing fast/dom/shadow/input-with-validation.html from the run list causes insertion-point-list-menu-crash.html to timeout, but removing input-with-validation-without-shadow.html from the list results in all the tests passing.

[Jussi Kukkonen (jku)]

(In reply to comment #1)
> We also have these bugs to track the crash:
> https://bugs.webkit.org/show_bug.cgi?id=98026
> https://bugs.webkit.org/show_bug.cgi?id=99886

These have different symptoms. I don't see why they'd be the same bug.

(In reply to comment #2)
> My first observation is that removing fast/dom/shadow/input-with-validation.html from the run list causes insertion-point-list-menu-crash.html to timeout, but removing input-with-validation-without-shadow.html from the list results in all the tests passing.

Well, I'll skip input-with-validation-without-shadow.html for now then. Can't keep the bot red all day.

[Yael]

When we run the test input-with-validation-without-shadow.html, we load immediately after that the ref test input-with-validation-without-shadow-expected.html .
The test sends a click event to the form control to submit it. At this point we start page transition and lock the tree. The page transition never finishes. When we try to dump the pixels for the test, the tree is locked.
It becomes unlocked only after the timeout expires and we load about:blank.

[Yael]

Created attachment 176620 [details]
Patch

Avoid submitting the ref test's form as discussed on iRC.

[Shinya Kawanaka]

Hi,

I'm the person who wrote the test. I'm sorry that my wrong test has bothered you.
Right, submit() should not be called in input-with-validation-without-shadow-expected.html .
Thank you for fixing it!

[Kent Tamura]

Comment on attachment 176620 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 176620 [details]
Patch

Clearing flags on attachment: 176620

Committed r136088: <http://trac.webkit.org/changeset/136088>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.