Bug 103495 - [EFL][WK2][AC] Clear the viewport with white color
Summary: [EFL][WK2][AC] Clear the viewport with white color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joone Hur
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-28 02:08 PST by Joone Hur
Modified: 2012-11-28 05:23 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2012-11-28 03:48 PST, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2012-11-28 02:08:02 PST
When we run MiniBrowser, the default viewport color is black. 
We need to change the color with white.
Comment 1 Joone Hur 2012-11-28 03:48:33 PST
Created attachment 176448 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-11-28 03:58:17 PST
Comment on attachment 176448 [details]
Patch

Wouldn't transparent not be better?
Comment 3 Joone Hur 2012-11-28 04:34:55 PST
(In reply to comment #2)
> (From update of attachment 176448 [details])
> Wouldn't transparent not be better?

Yes, maybe.
I checked the gtk+ port. It also clears the buffer with white color like this.
http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp#L300
Comment 4 Kenneth Rohde Christiansen 2012-11-28 04:39:25 PST
Sure but we are a mobile port and it should be possible to pan/pinch contents out of bounds and then have it bounce back again. In that case we don't want to show just white but be able to see the browser background below.

You can try the Qt MiniBrowser if you want to get an understanding of this. Maybe Thiago can show you, or you can try on an N9.
Comment 5 WebKit Review Bot 2012-11-28 04:46:41 PST
Comment on attachment 176448 [details]
Patch

Clearing flags on attachment: 176448

Committed r135997: <http://trac.webkit.org/changeset/135997>
Comment 6 WebKit Review Bot 2012-11-28 04:46:45 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Joone Hur 2012-11-28 05:23:31 PST
(In reply to comment #4)
> Sure but we are a mobile port and it should be possible to pan/pinch contents out of bounds and then have it bounce back again. In that case we don't want to show just white but be able to see the browser background below.
> 
> You can try the Qt MiniBrowser if you want to get an understanding of this. Maybe Thiago can show you, or you can try on an N9.

I'm not sure if all mobile browsers should have the same effect.
By the way, isn't this bounce effect an Apple patent?