RESOLVED FIXED 103486
Web Inspector: [Timeline] JS error when clicking in Memory Statistics view 
https://bugs.webkit.org/show_bug.cgi?id=103486
Summary Web Inspector: [Timeline] JS error when clicking in Memory Statistics view
Alexander Pavlov (apavlov)
Reported 2012-11-27 23:09:02 PST
Open an empty Memory view in the Timeline panel and click somewhere in the grid. You will get: Uncaught TypeError: Cannot read property 'time' of undefined at MemoryStatistics.js:320 (this._timelinePanel.revealRecordAt(counter.time / 1000);)
Attachments
Patch (1.68 KB, patch)
2012-11-30 01:47 PST, Sankeerth V S 		no flags
DetailsFormatted DiffDiff
Patch (1.78 KB, patch)
2012-11-30 02:14 PST, Sankeerth V S 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sankeerth V S
Comment 1 2012-11-30 01:47:01 PST
Created attachment 176924 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2012-11-30 01:55:08 PST
Comment on attachment 176924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176924&action=review Looks good! > Source/WebCore/inspector/front-end/MemoryStatistics.js:317 > var x = event.x - event.target.offsetParent.offsetLeft can you please add the missing trailing semicolon while we are here?
Sankeerth V S
Comment 3 2012-11-30 02:06:55 PST
Comment on attachment 176924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176924&action=review >> Source/WebCore/inspector/front-end/MemoryStatistics.js:317 >> var x = event.x - event.target.offsetParent.offsetLeft > > can you please add the missing trailing semicolon while we are here? sure. Will add it and upload a new patch.
Sankeerth V S
Comment 4 2012-11-30 02:14:20 PST
Created attachment 176929 [details] Patch
WebKit Review Bot
Comment 5 2012-11-30 02:53:16 PST
Comment on attachment 176929 [details] Patch Clearing flags on attachment: 176929 Committed r136220: <http://trac.webkit.org/changeset/136220>
WebKit Review Bot
Comment 6 2012-11-30 02:53:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.