Bug 103486 - Web Inspector: [Timeline] JS error when clicking in Memory Statistics view
Summary: Web Inspector: [Timeline] JS error when clicking in Memory Statistics view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 23:09 PST by Alexander Pavlov (apavlov)
Modified: 2012-11-30 02:53 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2012-11-30 01:47 PST, Sankeerth V S 		no flags Details | Formatted Diff | Diff
Patch (1.78 KB, patch)
2012-11-30 02:14 PST, Sankeerth V S 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-11-27 23:09:02 PST 
Open an empty Memory view in the Timeline panel and click somewhere in the grid. You will get:

Uncaught TypeError: Cannot read property 'time' of undefined
at MemoryStatistics.js:320 (this._timelinePanel.revealRecordAt(counter.time / 1000);)
Comment 1 Sankeerth V S 2012-11-30 01:47:01 PST 
Created attachment 176924 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-11-30 01:55:08 PST 
Comment on attachment 176924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176924&action=review

Looks good!

> Source/WebCore/inspector/front-end/MemoryStatistics.js:317
>          var x = event.x - event.target.offsetParent.offsetLeft

can you please add the missing trailing semicolon while we are here?
Comment 3 Sankeerth V S 2012-11-30 02:06:55 PST 
Comment on attachment 176924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176924&action=review

>> Source/WebCore/inspector/front-end/MemoryStatistics.js:317
>>          var x = event.x - event.target.offsetParent.offsetLeft
> 
> can you please add the missing trailing semicolon while we are here?

sure. Will add it and upload a new patch.
Comment 4 Sankeerth V S 2012-11-30 02:14:20 PST 
Created attachment 176929 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-30 02:53:16 PST 
Comment on attachment 176929 [details]
Patch

Clearing flags on attachment: 176929

Committed r136220: <http://trac.webkit.org/changeset/136220>
Comment 6 WebKit Review Bot 2012-11-30 02:53:19 PST 
All reviewed patches have been landed.  Closing bug.