We would like to make ShadowRoot as small as possible. Currently ShadowRoot has several ContentDistribution stuffs which are used only for ShadowRoot having <content>, <shadow> or nested ShadowRoot. We woud like to move them somewhere.
Apple folks seem to reduce memory footprint aggressively now.
Created attachment 176417 [details] Patch
Let's move DistributionData into ContentDistribution.h
Created attachment 176436 [details] Patch
Comment on attachment 176436 [details] Patch Attachment 176436 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15016356
Comment on attachment 176436 [details] Patch Attachment 176436 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15027358
Comment on attachment 176436 [details] Patch Attachment 176436 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15031177
Created attachment 176450 [details] Patch
Comment on attachment 176450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176450&action=review > Source/WebCore/ChangeLog:10 > + Since <input> or <textarea> do not have such stuffs, the members consume a few amount of memory. s/stuffs/stuff/ > Source/WebCore/dom/ShadowRoot.cpp:352 > + return distributionData()->numberOfShadowElementChildren() > 0; hasXXX could be a method on ShadowRootContentDistributionData > Source/WebCore/dom/ShadowRoot.cpp:370 > + return distributionData()->numberOfContentElementChildren() > 0; Ditto. > Source/WebCore/dom/ShadowRoot.cpp:389 > + return distributionData()->numberOfElementShadowChildren() > 0; Ditto.
Comment on attachment 176450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176450&action=review >> Source/WebCore/ChangeLog:10 >> + Since <input> or <textarea> do not have such stuffs, the members consume a few amount of memory. > > s/stuffs/stuff/ s/stuffs/requirements/ </bikeshed>
Created attachment 176617 [details] Patch for landing
Comment on attachment 176617 [details] Patch for landing Clearing flags on attachment: 176617 Committed r136081: <http://trac.webkit.org/changeset/136081>
All reviewed patches have been landed. Closing bug.