Bug 103481 - [Shadow] Move Distribution requirements from ShadowRoot
Summary: [Shadow] Move Distribution requirements from ShadowRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 97279
  Show dependency treegraph
 
Reported: 2012-11-27 22:21 PST by Shinya Kawanaka
Modified: 2012-11-28 18:19 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.19 KB, patch)
2012-11-28 00:33 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (13.42 KB, patch)
2012-11-28 02:48 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (18.01 KB, patch)
2012-11-28 03:57 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (18.01 KB, patch)
2012-11-28 17:58 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-27 22:21:00 PST
We would like to make ShadowRoot as small as possible.
Currently ShadowRoot has several ContentDistribution stuffs which are used only for ShadowRoot having <content>, <shadow> or nested ShadowRoot.
We woud like to move them somewhere.
Comment 1 Shinya Kawanaka 2012-11-28 00:32:36 PST
Apple folks seem to reduce memory footprint aggressively now.
Comment 2 Shinya Kawanaka 2012-11-28 00:33:31 PST
Created attachment 176417 [details]
Patch
Comment 3 Shinya Kawanaka 2012-11-28 01:49:09 PST
Let's move DistributionData into ContentDistribution.h
Comment 4 Shinya Kawanaka 2012-11-28 02:48:10 PST
Created attachment 176436 [details]
Patch
Comment 5 Build Bot 2012-11-28 03:03:45 PST
Comment on attachment 176436 [details]
Patch

Attachment 176436 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15016356
Comment 6 kov's GTK+ EWS bot 2012-11-28 03:16:32 PST
Comment on attachment 176436 [details]
Patch

Attachment 176436 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15027358
Comment 7 Build Bot 2012-11-28 03:23:37 PST
Comment on attachment 176436 [details]
Patch

Attachment 176436 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15031177
Comment 8 Shinya Kawanaka 2012-11-28 03:57:32 PST
Created attachment 176450 [details]
Patch
Comment 9 Hajime Morrita 2012-11-28 06:09:02 PST
Comment on attachment 176450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176450&action=review

> Source/WebCore/ChangeLog:10
> +        Since <input> or <textarea> do not have such stuffs, the members consume a few amount of memory.

s/stuffs/stuff/

> Source/WebCore/dom/ShadowRoot.cpp:352
> +    return distributionData()->numberOfShadowElementChildren() > 0;

hasXXX could be a method on ShadowRootContentDistributionData

> Source/WebCore/dom/ShadowRoot.cpp:370
> +    return distributionData()->numberOfContentElementChildren() > 0;

Ditto.

> Source/WebCore/dom/ShadowRoot.cpp:389
> +    return distributionData()->numberOfElementShadowChildren() > 0;

Ditto.
Comment 10 Dimitri Glazkov (Google) 2012-11-28 08:41:33 PST
Comment on attachment 176450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176450&action=review

>> Source/WebCore/ChangeLog:10
>> +        Since <input> or <textarea> do not have such stuffs, the members consume a few amount of memory.
> 
> s/stuffs/stuff/

s/stuffs/requirements/ </bikeshed>
Comment 11 Shinya Kawanaka 2012-11-28 17:58:13 PST
Created attachment 176617 [details]
Patch for landing
Comment 12 WebKit Review Bot 2012-11-28 18:19:10 PST
Comment on attachment 176617 [details]
Patch for landing

Clearing flags on attachment: 176617

Committed r136081: <http://trac.webkit.org/changeset/136081>
Comment 13 WebKit Review Bot 2012-11-28 18:19:14 PST
All reviewed patches have been landed.  Closing bug.