Bug 103476 - [GTK] [WebKit2] WebKitWebViewBase creates a GL context for the redirected XComposite window crashing WebKit in Xvfb
Summary: [GTK] [WebKit2] WebKitWebViewBase creates a GL context for the redirected XCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL: http:/inadvertently
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 18:43 PST by Martin Robinson
Modified: 2012-11-29 22:42 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.55 KB, patch)
2012-11-29 12:32 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-11-27 18:43:58 PST 
WebKitWebViewBase creates a GL context for the redirected XComposite window crashing WebKit in Xvfb. This is a result of sharing the RedirectedXComposite window implementation between WebKit1 and WebKit2. In WebKit2, we should not create a GLXContext during resize events.
Comment 1 Martin Robinson 2012-11-29 12:32:33 PST 
Created attachment 176789 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-29 12:38:17 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alejandro G. Castro 2012-11-29 14:44:22 PST 
Comment on attachment 176789 [details]
Patch

LGTM
Comment 4 WebKit Review Bot 2012-11-29 14:59:58 PST 
Comment on attachment 176789 [details]
Patch

Rejecting attachment 176789 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 159.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15044467
Comment 5 Martin Robinson 2012-11-29 22:42:24 PST 
Comment on attachment 176789 [details]
Patch

Clearing flags on attachment: 176789

Committed r136207: <http://trac.webkit.org/changeset/136207>
Comment 6 Martin Robinson 2012-11-29 22:42:27 PST 
All reviewed patches have been landed.  Closing bug.