Bug 103476 – [GTK] [WebKit2] WebKitWebViewBase creates a GL context for the redirected XComposite window crashing WebKit in Xvfb

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

WebKitWebViewBase creates a GL context for the redirected XComposite window crashing WebKit in Xvfb. This is a result of sharing the RedirectedXComposite window implementation between WebKit1 and WebKit2. In WebKit2, we should not create a GLXContext during resize events.

[Martin Robinson]

Created attachment 176789 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Alejandro G. Castro]

Comment on attachment 176789 [details]
Patch

LGTM

[WebKit Review Bot]

Comment on attachment 176789 [details]
Patch

Rejecting attachment 176789 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 159.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15044467

[Martin Robinson]

Comment on attachment 176789 [details]
Patch

Clearing flags on attachment: 176789

Committed r136207: <http://trac.webkit.org/changeset/136207>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.