Bug 103474 - [Refactoring] HasSelectorForClassStyleFunctor in Element.cpp seems verbose
Summary: [Refactoring] HasSelectorForClassStyleFunctor in Element.cpp seems verbose
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
Depends on: 100738
  Show dependency treegraph
Reported: 2012-11-27 18:04 PST by Shinya Kawanaka
Modified: 2012-11-28 02:52 PST (History)
5 users (show)

See Also:

Patch (7.06 KB, patch)
2012-11-27 19:01 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (7.08 KB, patch)
2012-11-27 20:14 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-27 18:04:01 PST
This is a follow-up bug for Bug 100738.
The added code seems verbose, so let's make it simple.
Comment 1 Shinya Kawanaka 2012-11-27 19:01:02 PST
Created attachment 176384 [details]
Comment 2 Hajime Morrita 2012-11-27 19:02:19 PST
Comment on attachment 176384 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=176384&action=review

> Source/WebCore/dom/Element.cpp:839
> +template<typename T>

Could you give more descriptive name instead of T?
Comment 3 Shinya Kawanaka 2012-11-27 20:14:55 PST
Created attachment 176387 [details]
Comment 4 WebKit Review Bot 2012-11-27 20:38:09 PST
Comment on attachment 176387 [details]

Clearing flags on attachment: 176387

Committed r135967: <http://trac.webkit.org/changeset/135967>
Comment 5 WebKit Review Bot 2012-11-27 20:38:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Antti Koivisto 2012-11-28 02:52:24 PST
Much better!