Bug 103462 - run-perf-tests fails on Android because of stderr output
Summary: run-perf-tests fails on Android because of stderr output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 16:08 PST by Adam Barth
Modified: 2012-11-27 16:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2012-11-27 16:09 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (3.32 KB, patch)
2012-11-27 16:15 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (3.34 KB, patch)
2012-11-27 16:19 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-11-27 16:08:06 PST 
run-perf-tests fails on Android because of stderr output
Comment 1 Adam Barth 2012-11-27 16:09:31 PST 
Created attachment 176357 [details]
Patch
Comment 2 Ryosuke Niwa 2012-11-27 16:10:44 PST 
Comment on attachment 176357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176357&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:106
> +        re.compile(r'^Unknown option:'),
> +        re.compile(r'^\[WARNING:')]

Can we be more specific about warnings?
Comment 3 Adam Barth 2012-11-27 16:11:46 PST 
Comment on attachment 176357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176357&action=review

>> Tools/Scripts/webkitpy/performance_tests/perftest.py:106
>> +        re.compile(r'^\[WARNING:')]
> 
> Can we be more specific about warnings?

On IRC we discussed limiting this to proxy_service.cc
Comment 4 Adam Barth 2012-11-27 16:15:11 PST 
Created attachment 176361 [details]
Patch
Comment 5 Adam Barth 2012-11-27 16:19:13 PST 
Created attachment 176363 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-27 16:40:54 PST 
Comment on attachment 176363 [details]
Patch

Clearing flags on attachment: 176363

Committed r135942: <http://trac.webkit.org/changeset/135942>
Comment 7 WebKit Review Bot 2012-11-27 16:40:57 PST 
All reviewed patches have been landed.  Closing bug.