Gut WebRenderingStats since we no longer use its member variables.
Created attachment 176352 [details] Patch
jamesr: please take a look - should be the last time we need to modify WebRenderingStats.
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 176352 [details] Patch R+, will you be removing the struct as well?
(In reply to comment #4) > (From update of attachment 176352 [details]) > R+, will you be removing the struct as well? No, unfortunately we still need to empty struct for inheritance and downcasting on the chromium side.
Comment on attachment 176352 [details] Patch Rejecting attachment 176352 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: bkit/compositor_bindings/web_layer_tree_view_impl.cc:187: error: 'struct WebKit::WebRenderingStats' has no member named 'numImplThreadScrolls' Source/WebKit/chromium/webkit/compositor_bindings/web_layer_tree_view_impl.cc:188: error: 'struct WebKit::WebRenderingStats' has no member named 'numMainThreadScrolls' make: *** [out/Release/obj.target/webkit_compositor_bindings/Source/WebKit/chromium/webkit/compositor_bindings/web_layer_tree_view_impl.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/15010304
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 176352 [details] [details]) > > R+, will you be removing the struct as well? > > No, unfortunately we still need to empty struct for inheritance and downcasting on the chromium side. We'll be able to completely remove it when https://code.google.com/p/chromium/issues/detail?id=156175 is fixed
Comment on attachment 176352 [details] Patch Attachment 176352 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15013268
Comment on attachment 176352 [details] Patch Attachment 176352 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15023256
Created attachment 176502 [details] Patch
Re-uploading patch to rerun bots now that chromium DEPS should be up-to-date.
Comment on attachment 176502 [details] Patch Attachment 176502 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15027463
Created attachment 176733 [details] Patch
(In reply to comment #11) > Re-uploading patch to rerun bots now that chromium DEPS should be up-to-date. Even though the DEPS had been updated, looks like they hadn't propagated to the cr-linux bot. Trying again...
Comment on attachment 176733 [details] Patch Clearing flags on attachment: 176733 Committed r136511: <http://trac.webkit.org/changeset/136511>
All reviewed patches have been landed. Closing bug.