RESOLVED FIXED 103459
Shrink ShadowRoot and TreeScope. 
https://bugs.webkit.org/show_bug.cgi?id=103459
Summary Shrink ShadowRoot and TreeScope.
Andreas Kling
Reported 2012-11-27 15:44:46 PST
These could be smaller, we're wasting a lot of memory on ShadowRoots right now due to the inline DocumentOrderedMaps.
Attachments
Proposed patch (10.72 KB, patch)
2012-11-27 15:45 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-11-27 15:45:50 PST
Created attachment 176351 [details] Proposed patch
Antti Koivisto
Comment 2 2012-11-27 16:01:17 PST
Comment on attachment 176351 [details] Proposed patch r=me
Ojan Vafai
Comment 3 2012-11-27 16:01:35 PST
Comment on attachment 176351 [details] Proposed patch Mind adding COMPILE_ASSERTS for the sizes of TreeScope and ShadowRoot? Ideally you'd commit that first so that we could see the improvement from this patch.
Andreas Kling
Comment 4 2012-11-27 16:02:19 PST
(In reply to comment #3) > (From update of attachment 176351 [details]) > Mind adding COMPILE_ASSERTS for the sizes of TreeScope and ShadowRoot? Ideally you'd commit that first so that we could see the improvement from this patch. Sure, will do!
WebKit Review Bot
Comment 5 2012-11-27 16:35:08 PST
Comment on attachment 176351 [details] Proposed patch Clearing flags on attachment: 176351 Committed r135939: <http://trac.webkit.org/changeset/135939>
WebKit Review Bot
Comment 6 2012-11-27 16:35:12 PST
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 7 2012-11-27 16:36:11 PST
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 176351 [details] [details]) > > Mind adding COMPILE_ASSERTS for the sizes of TreeScope and ShadowRoot? Ideally you'd commit that first so that we could see the improvement from this patch. > > Sure, will do! Aw crap, forgot about the CQ. Well, I'll slap some compile asserts on there anyway. Better late than never.
Ojan Vafai
Comment 8 2012-11-27 21:57:36 PST
Yeah, no worries. Better late than never indeed!
Note You need to log in before you can comment on or make changes to this bug.