Bug 103413 – TextTrackCue's .endTime property should fire a TypeError when NaN is assigned

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

We're failing the Opera-submitted test at http://w3c-test.org/html/tests/submission/Opera/media/interfaces/TextTrackCue/endTime.html due to not triggering a TypeError when trying to set .endTime to NaN, which is not an appropriate value.

[Radar WebKit Bug Importer]

<rdar://problem/12758008>

[Antoine Quint]

We run into the same issue for .startTime as shown in http://w3c-test.org/html/tests/submission/Opera/media/interfaces/TextTrackCue/startTime.html.

[Antoine Quint]

Created attachment 177486 [details]
Patch

[Eric Carlson]

Comment on attachment 177486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177486&action=review

> Source/WebCore/html/track/TextTrackCue.cpp:273
> +    if (WTF::double_conversion::Double(value).IsSpecial()) {

I don't see Double() being used to test this anywhere else in WebCore, and while I don't know enough about it to know that it is a problem I would rather we stick with the more commonly used isinf() and isnan(). Note that you don't need to test for negative vs. positive infinity as inf() returns true for either (eg. see MediaTime::createWithDouble).

> Source/WebCore/html/track/TextTrackCue.cpp:290
> +    if (WTF::double_conversion::Double(value).IsSpecial()) {

Ditto.

> LayoutTests/media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:3
> +PASS TextTrackCue.endTime, script-created cue 
> +TIMEOUT TextTrackCue.endTime, parsed cue Test timed out

TIMEOUT? ChangeLog should note this if it is intentional.

> LayoutTests/media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:3
> +PASS TextTrackCue.startTime, script-created cue 
> +TIMEOUT TextTrackCue.startTime, parsed cue Test timed out

Ditto.

[Antoine Quint]

(In reply to comment #4)
> (From update of attachment 177486 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177486&action=review
> 
> > Source/WebCore/html/track/TextTrackCue.cpp:273
> > +    if (WTF::double_conversion::Double(value).IsSpecial()) {
> 
> I don't see Double() being used to test this anywhere else in WebCore, and while I don't know enough about it to know that it is a problem I would rather we stick with the more commonly used isinf() and isnan(). Note that you don't need to test for negative vs. positive infinity as inf() returns true for either (eg. see MediaTime::createWithDouble).

Will adopt the isnan() and is infinite() methods from wtf/MathExtras.h in an updated patch.

> > LayoutTests/media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:3
> > +PASS TextTrackCue.endTime, script-created cue 
> > +TIMEOUT TextTrackCue.endTime, parsed cue Test timed out
> 
> TIMEOUT? ChangeLog should note this if it is intentional.

It is intentional and the LayoutTests/ChangeLog mentioned the blocking bug (https://bugs.webkit.org/show_bug.cgi?id=103258).

[Antoine Quint]

Created attachment 177737 [details]
Patch

[WebKit Review Bot]

Comment on attachment 177737 [details]
Patch

Clearing flags on attachment: 177737

Committed r136684: <http://trac.webkit.org/changeset/136684>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.