Bug 103408 - Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
Summary: Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 07:00 PST by Zan Dobersek
Modified: 2012-11-28 08:16 PST (History)
4 users (show)

See Also:


Attachments
Patch (165.27 KB, patch)
2012-11-27 07:03 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-11-27 07:00:23 PST
Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
Comment 1 Zan Dobersek 2012-11-27 07:03:54 PST
Created attachment 176261 [details]
Patch
Comment 2 Dirk Pranke 2012-11-27 13:11:46 PST
Comment on attachment 176261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176261&action=review

lgtm (mostly a rubber-stamp).

> Tools/Scripts/webkitpy/tool/commands/queues_unittest.py:413
> +bar/baz-diffs.txt does not exist in results archive, uploading entire archive.

I wonder where this line comes in from ... ?
Comment 3 WebKit Review Bot 2012-11-27 13:32:55 PST
Comment on attachment 176261 [details]
Patch

Clearing flags on attachment: 176261

Committed r135912: <http://trac.webkit.org/changeset/135912>
Comment 4 WebKit Review Bot 2012-11-27 13:32:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Zan Dobersek 2012-11-28 08:16:14 PST
Comment on attachment 176261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176261&action=review

>> Tools/Scripts/webkitpy/tool/commands/queues_unittest.py:413
>> +bar/baz-diffs.txt does not exist in results archive, uploading entire archive.
> 
> I wonder where this line comes in from ... ?

It was always there, but was reported through the Logger in flakytestreporter.py[1]. Until now this unit test only checked expected stderr output, but the output was now moved into log form where this line also pops up.

[1] http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py#L169