Bug 103401 – Inline ImageFrame width() and height()

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[noel gordon]

Per https://bugs.webkit.org/show_bug.cgi?id=88424#c38, we should inline ImageFrame width() and height().

[noel gordon]

Created attachment 176241 [details]
Patch

[Brent Fulgham]

Comment on attachment 176241 [details]
Patch

Looks great. r=me.

[WebKit Review Bot]

Comment on attachment 176241 [details]
Patch

Clearing flags on attachment: 176241

Committed r135971: <http://trac.webkit.org/changeset/135971>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Comment on attachment 176241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review

> Source/WebCore/platform/image-decoders/ImageDecoder.h:199
> +            return m_size.width();

Oh oh. Should be height, not width. This is causing a lot of failures.

[Brent Fulgham]

Comment on attachment 176241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review

>> Source/WebCore/platform/image-decoders/ImageDecoder.h:199
>> +            return m_size.width();
> 
> Oh oh. Should be height, not width. This is causing a lot of failures.

Doh!  How did I miss this.  :-(  Mea culpa.

[Zan Dobersek]

(In reply to comment #5)
> (From update of attachment 176241 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review
> 
> > Source/WebCore/platform/image-decoders/ImageDecoder.h:199
> > +            return m_size.width();
> 
> Oh oh. Should be height, not width. This is causing a lot of failures.

Just to address this, it has been fixed in r135980.
http://trac.webkit.org/changeset/135980