Bug 103398 – OpenCL version of FEColorMatrix

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Tamas Czene]

FEColorMatrix filter need to be implemented on OpenCL.

[Tamas Czene]

Created attachment 176413 [details]
draft patch

[Tamas Czene]

Created attachment 178807 [details]
proposed patch

Benchmark results:

Qt Linux:
GPU: NVIDIA GeForce GT 440
CUDA Cores 96

CPU: Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz
4 Core

Software: 3 fps
OpenCL GPU: 15 fps

[Zoltan Herczeg]

Could you attach the source code of the benchmark as well?

[Tamas Czene]

Created attachment 178983 [details]
svg file

[Zoltan Herczeg]

Comment on attachment 178807 [details]
proposed patch

The patch looks good, only a few changes:

View in context: https://bugs.webkit.org/attachment.cgi?id=178807&action=review

> Source/WebCore/ChangeLog:4
> +        OpenCL version of FEColorMatrix.
> +        https://bugs.webkit.org/show_bug.cgi?id=103398

Where is the "revewed by" line?

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:52
> +    values[5]  * sourcePixel.x + values[6]  * sourcePixel.y + values[7]  * sourcePixel.z + values[8]  * sourcePixel.w + values[9],
> +    values[10] * sourcePixel.x + values[11] * sourcePixel.y + values[12] * sourcePixel.z + values[13] * sourcePixel.w + values[14],
> +    values[15] * sourcePixel.x + values[16] * sourcePixel.y + values[17] * sourcePixel.z + values[18] * sourcePixel.w + values[19])

+4 space indentation

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:60
> +    sourcePixel.x * components[3] + sourcePixel.y * components[4] + sourcePixel.z * components[5],  
> +    sourcePixel.x * components[6] + sourcePixel.y * components[7] + sourcePixel.z * components[8],  
> +    sourcePixel.w)

ditto.

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:112
> +        colorMatrix = 0;

return. 0 is an invalid value. And an ASSERT_NOT_REACHED()

> Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:141
> +    absolutePaintRect().x() - in->absolutePaintRect().location().x(),
> +    absolutePaintRect().y() - in->absolutePaintRect().location().y());

Indentation again.

[Tamas Czene]

Created attachment 179248 [details]
proposed patch

[Zoltan Herczeg]

Comment on attachment 179248 [details]
proposed patch

r=me nice patch.

[WebKit Review Bot]

Comment on attachment 179248 [details]
proposed patch

Clearing flags on attachment: 179248

Committed r137591: <http://trac.webkit.org/changeset/137591>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.