Bug 103389 – PDFPlugin: "Show Definition" context menu item should be implemented

• Status: RESOLVED
• Resolution: FIXED
• Component: PDF

[Tim Horton]

<rdar://problem/12710751>

[Tim Horton]

Created attachment 176229 [details]
patch

[WebKit Review Bot]

Attachment 176229 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:70:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:70:  The parameter name "point" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 176229 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176229&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:725
> +    NSMutableDictionary *fontDescriptorAttributes = [[[font fontDescriptor] fontAttributes] mutableCopy];

Whoops, this leaks. Will fix tomorrow.

[Alexey Proskuryakov]

Comment on attachment 176229 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176229&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:718
> +    NSDictionary *attributes = [string attributesAtIndex:0 effectiveRange:0];

What makes attributes at this particular index special?

[Tim Horton]

Comment on attachment 176229 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176229&action=review

>> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:718
>> +    NSDictionary *attributes = [string attributesAtIndex:0 effectiveRange:0];
> 
> What makes attributes at this particular index special?

We can only have one font for the dictionary popup, so why not the font at the beginning of the attributed string?

I believe this is effectively identical to what WebPageMac does with its Ranges for web content.

[Tim Horton]

Created attachment 176614 [details]
patch (much simplified)

Comment on attachment 176614 [details]
patch (much simplified)

View in context: https://bugs.webkit.org/attachment.cgi?id=176614&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:780
> +    dictionaryPopupInfo.origin = convertFromPDFViewToRootView(IntPoint(point));

Is the IntPoint() necessary?

[Tim Horton]

(In reply to comment #7)
> (From update of attachment 176614 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176614&action=review
> 
> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:780
> > +    dictionaryPopupInfo.origin = convertFromPDFViewToRootView(IntPoint(point));
> 
> Is the IntPoint() necessary?

It is.

Thanks, Dan!

http://trac.webkit.org/changeset/136260