Bug 103387 - PDFPlugin: Should not be able to edit read-only text annotations
Summary: PDFPlugin: Should not be able to edit read-only text annotations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-27 03:19 PST by Tim Horton
Modified: 2012-11-27 17:34 PST (History)
3 users (show)

See Also:


Attachments
patch (2.45 KB, patch)
2012-11-27 03:21 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (6.71 KB, patch)
2012-11-27 16:43 PST, Tim Horton
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-11-27 03:19:17 PST
<rdar://problem/12752313>

For example, some parts of http://www.irs.gov/pub/irs-pdf/f1099msc.pdf are read only.
Comment 1 Tim Horton 2012-11-27 03:21:48 PST
Created attachment 176219 [details]
patch
Comment 2 Alexey Proskuryakov 2012-11-27 08:29:20 PST
It is very rare for create() to do anything besides wrapping a constructor. I'm not sure if this is the best place to have such logic.
Comment 3 Tim Horton 2012-11-27 13:52:22 PST
(In reply to comment #2)
> It is very rare for create() to do anything besides wrapping a constructor. I'm not sure if this is the best place to have such logic.

OK, I'll move it earlier.
Comment 4 Tim Horton 2012-11-27 16:43:43 PST
Created attachment 176370 [details]
patch
Comment 5 WebKit Review Bot 2012-11-27 16:48:27 PST
Attachment 176370 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h:28:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2012-11-27 17:34:44 PST
Thanks, Alexey!

http://trac.webkit.org/changeset/135958