RESOLVED FIXED 103387
PDFPlugin: Should not be able to edit read-only text annotations 
https://bugs.webkit.org/show_bug.cgi?id=103387
Summary PDFPlugin: Should not be able to edit read-only text annotations
Tim Horton
Reported 2012-11-27 03:19:17 PST
<rdar://problem/12752313> For example, some parts of http://www.irs.gov/pub/irs-pdf/f1099msc.pdf are read only.
Attachments
patch (2.45 KB, patch)
2012-11-27 03:21 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (6.71 KB, patch)
2012-11-27 16:43 PST, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2012-11-27 03:21:48 PST
Created attachment 176219 [details] patch
Alexey Proskuryakov
Comment 2 2012-11-27 08:29:20 PST
It is very rare for create() to do anything besides wrapping a constructor. I'm not sure if this is the best place to have such logic.
Tim Horton
Comment 3 2012-11-27 13:52:22 PST
(In reply to comment #2) > It is very rare for create() to do anything besides wrapping a constructor. I'm not sure if this is the best place to have such logic. OK, I'll move it earlier.
Tim Horton
Comment 4 2012-11-27 16:43:43 PST
Created attachment 176370 [details] patch
WebKit Review Bot
Comment 5 2012-11-27 16:48:27 PST
Attachment 176370 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h:28: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 6 2012-11-27 17:34:44 PST
Thanks, Alexey! http://trac.webkit.org/changeset/135958
Note You need to log in before you can comment on or make changes to this bug.