RESOLVED FIXED 103385
Fix world-reuse test for mac build 
https://bugs.webkit.org/show_bug.cgi?id=103385
Summary Fix world-reuse test for mac build
Dan Carney
Reported 2012-11-27 02:50:30 PST
Fix world-reuse test for mac build
Attachments
Patch (1.71 KB, patch)
2012-11-27 02:53 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2012-11-27 02:53:02 PST
Created attachment 176217 [details] Patch
jochen
Comment 2 2012-11-27 02:57:17 PST
you probably also need to remove the wrong test expectations for jsc ports?
Dan Carney
Comment 3 2012-11-27 03:00:01 PST
(In reply to comment #2) > you probably also need to remove the wrong test expectations for jsc ports? they weren't added, so this just makes the expectations work for all ports.
jochen
Comment 4 2012-11-27 03:09:15 PST
Comment on attachment 176217 [details] Patch ok
Adam Barth
Comment 5 2012-11-27 09:21:12 PST
Comment on attachment 176217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176217&action=review We can land this patch to make the test pass, but we really should make the test harness behave the same way across ports do we don't run into this issue again. > LayoutTests/ChangeLog:9 > + Mac and chrome builds have different expectations for where > + an isolated world is executed. We should change the test harness to work the same way.
WebKit Review Bot
Comment 6 2012-11-27 09:59:49 PST
Comment on attachment 176217 [details] Patch Clearing flags on attachment: 176217 Committed r135871: <http://trac.webkit.org/changeset/135871>
WebKit Review Bot
Comment 7 2012-11-27 09:59:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.