Bug 103385 - Fix world-reuse test for mac build
Summary: Fix world-reuse test for mac build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-27 02:50 PST by Dan Carney
Modified: 2012-11-27 09:59 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2012-11-27 02:53 PST, Dan Carney 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Carney 2012-11-27 02:50:30 PST 
Fix world-reuse test for mac build
Comment 1 Dan Carney 2012-11-27 02:53:02 PST 
Created attachment 176217 [details]
Patch
Comment 2 jochen 2012-11-27 02:57:17 PST 
you probably also need to remove the wrong test expectations for jsc ports?
Comment 3 Dan Carney 2012-11-27 03:00:01 PST 
(In reply to comment #2)
> you probably also need to remove the wrong test expectations for jsc ports?

they weren't added, so this just makes the expectations work for all ports.
Comment 4 jochen 2012-11-27 03:09:15 PST 
Comment on attachment 176217 [details]
Patch

ok
Comment 5 Adam Barth 2012-11-27 09:21:12 PST 
Comment on attachment 176217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176217&action=review

We can land this patch to make the test pass, but we really should make the test harness behave the same way across ports do we don't run into this issue again.

> LayoutTests/ChangeLog:9
> +        Mac and chrome builds have different expectations for where
> +        an isolated world is executed. 

We should change the test harness to work the same way.
Comment 6 WebKit Review Bot 2012-11-27 09:59:49 PST 
Comment on attachment 176217 [details]
Patch

Clearing flags on attachment: 176217

Committed r135871: <http://trac.webkit.org/changeset/135871>
Comment 7 WebKit Review Bot 2012-11-27 09:59:52 PST 
All reviewed patches have been landed.  Closing bug.