Bug 103376 – [V8] add contextForWorld helper function to ScriptController

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dan Carney]

[V8] add contextForWorld helper function to ScriptController

[Dan Carney]

Created attachment 176195 [details]
Patch

[Kentaro Hara]

Comment on attachment 176195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176195&action=review

> Source/WebCore/bindings/v8/ScriptController.cpp:437
> +inline v8::Local<v8::Context> ScriptController::contextForWorld(DOMWrapperWorld* world)

This could be in a header file. Maybe you couldn't write it in a header file due to some #include dependency problem ?

[Dan Carney]

(In reply to comment #2)
> (From update of attachment 176195 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176195&action=review
> 
> > Source/WebCore/bindings/v8/ScriptController.cpp:437
> > +inline v8::Local<v8::Context> ScriptController::contextForWorld(DOMWrapperWorld* world)
> 
> This could be in a header file. Maybe you couldn't write it in a header file due to some #include dependency problem ?

I will move it to the header, i just wanted all the uses of the function in the same spot as the function.

[Kentaro Hara]

ok, if performance is not critical, it would make sense to put it in a cpp file as a static function.

[Dan Carney]

Created attachment 176201 [details]
Patch

[Dan Carney]

Comment on attachment 176201 [details]
Patch

static inline version

[WebKit Review Bot]

Comment on attachment 176201 [details]
Patch

Rejecting attachment 176201 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15016026

[WebKit Review Bot]

Comment on attachment 176201 [details]
Patch

Clearing flags on attachment: 176201

Committed r135846: <http://trac.webkit.org/changeset/135846>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

Comment on attachment 176201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176201&action=review

> Source/WebCore/bindings/v8/ScriptController.cpp:437
> +static inline v8::Local<v8::Context> contextForWorld(ScriptController* scriptController, DOMWrapperWorld* world)

Minor style nit: We usually put functions like this at the top of the file, just after the namespace WebCore.

Also, my understanding is that static and inline are redundant here.