WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
103370
[Refactoring] NodeFlags::IsShadowRootFlag should be Node::IsDocumentFragmentFlag
https://bugs.webkit.org/show_bug.cgi?id=103370
Summary
[Refactoring] NodeFlags::IsShadowRootFlag should be Node::IsDocumentFragmentFlag
Hajime Morrita
Reported
2012-11-27 00:00:43 PST
DocumentFragment check is on a hot path and can be done by a node flag check.
Attachments
Patch
(6.20 KB, patch)
2012-11-27 00:28 PST
,
Hajime Morrita
haraken
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hajime Morrita
Comment 1
2012-11-27 00:28:19 PST
Created
attachment 176191
[details]
Patch
Kentaro Hara
Comment 2
2012-11-27 00:43:06 PST
Comment on
attachment 176191
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=176191&action=review
r+ing assuming that the perf impact on isShadowRoot()==true is acceptable.
> Source/WebCore/ChangeLog:8 > + This chagne introduces Node::IsDocumentFragmentFlag so that we can
Typo: change.
Hajime Morrita
Comment 3
2012-11-27 00:51:28 PST
Committed
r135833
: <
http://trac.webkit.org/changeset/135833
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug