Bug 103370 - [Refactoring] NodeFlags::IsShadowRootFlag should be Node::IsDocumentFragmentFlag
Summary: [Refactoring] NodeFlags::IsShadowRootFlag should be Node::IsDocumentFragmentFlag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on: 103372
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-27 00:00 PST by Hajime Morrita
Modified: 2012-11-27 00:51 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.20 KB, patch)
2012-11-27 00:28 PST, Hajime Morrita 		haraken: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-11-27 00:00:43 PST 
DocumentFragment check is on a hot path and can be done by a node flag check.
Comment 1 Hajime Morrita 2012-11-27 00:28:19 PST 
Created attachment 176191 [details]
Patch
Comment 2 Kentaro Hara 2012-11-27 00:43:06 PST 
Comment on attachment 176191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176191&action=review

r+ing assuming that the perf impact on isShadowRoot()==true is acceptable.

> Source/WebCore/ChangeLog:8
> +        This chagne introduces Node::IsDocumentFragmentFlag so that we can

Typo: change.
Comment 3 Hajime Morrita 2012-11-27 00:51:28 PST 
Committed r135833: <http://trac.webkit.org/changeset/135833>