RESOLVED FIXED 103352
[V8] Rename EXCEPTION_BLOCK() macros 
https://bugs.webkit.org/show_bug.cgi?id=103352
Summary [V8] Rename EXCEPTION_BLOCK() macros
Kentaro Hara
Reported 2012-11-26 20:44:04 PST
EXCEPTION_BLOCK() => TRYCATCH() STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() => TRYCATCH_FOR_V8STRINGRESOURCE() STRING_TO_V8PARAMETER_EXCEPTION_BLOCK_VOID() => TRYCATCH_FOR_V8STRINGRESOURCE_VOID() Any suggestion?
Attachments
Patch (84.25 KB, patch)
2012-11-26 20:57 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (84.20 KB, patch)
2012-11-26 21:10 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-26 20:57:20 PST
Created attachment 176159 [details] Patch
Adam Barth
Comment 2 2012-11-26 21:07:49 PST
I might have used V8 prefixes (e.g., V8TRYCATCH), but this is fine too.
Kentaro Hara
Comment 3 2012-11-26 21:10:29 PST
Created attachment 176163 [details] patch for landing
Kentaro Hara
Comment 4 2012-11-26 21:11:01 PST
Comment on attachment 176163 [details] patch for landing > I might have used V8 prefixes (e.g., V8TRYCATCH), but this is fine too. Done. Thanks.
WebKit Review Bot
Comment 5 2012-11-26 21:33:53 PST
Comment on attachment 176163 [details] patch for landing Clearing flags on attachment: 176163 Committed r135817: <http://trac.webkit.org/changeset/135817>
WebKit Review Bot
Comment 6 2012-11-26 21:33:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.