Bug 103352 - [V8] Rename EXCEPTION_BLOCK() macros
Summary: [V8] Rename EXCEPTION_BLOCK() macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 20:44 PST by Kentaro Hara
Modified: 2012-11-26 21:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (84.25 KB, patch)
2012-11-26 20:57 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (84.20 KB, patch)
2012-11-26 21:10 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-26 20:44:04 PST 
EXCEPTION_BLOCK() => TRYCATCH()
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() => TRYCATCH_FOR_V8STRINGRESOURCE()
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK_VOID() => TRYCATCH_FOR_V8STRINGRESOURCE_VOID()

Any suggestion?
Comment 1 Kentaro Hara 2012-11-26 20:57:20 PST 
Created attachment 176159 [details]
Patch
Comment 2 Adam Barth 2012-11-26 21:07:49 PST 
I might have used V8 prefixes (e.g., V8TRYCATCH), but this is fine too.
Comment 3 Kentaro Hara 2012-11-26 21:10:29 PST 
Created attachment 176163 [details]
patch for landing
Comment 4 Kentaro Hara 2012-11-26 21:11:01 PST 
Comment on attachment 176163 [details]
patch for landing

> I might have used V8 prefixes (e.g., V8TRYCATCH), but this is fine too.

Done. Thanks.
Comment 5 WebKit Review Bot 2012-11-26 21:33:53 PST 
Comment on attachment 176163 [details]
patch for landing

Clearing flags on attachment: 176163

Committed r135817: <http://trac.webkit.org/changeset/135817>
Comment 6 WebKit Review Bot 2012-11-26 21:33:56 PST 
All reviewed patches have been landed.  Closing bug.