NEW 103345
IDL attribute [SuppressToJSObject] is no longer used 
https://bugs.webkit.org/show_bug.cgi?id=103345
Summary IDL attribute [SuppressToJSObject] is no longer used
Kentaro Hara
Reported Tuesday, November 27, 2012 3:32:16 AM UTC
We can remove [SuppressToJSObject] from code generators.
Attachments
Patch (3.55 KB, patch)
2012-11-26 19:34 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (4.05 KB, patch)
2012-11-26 20:47 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (9.43 KB, patch)
2012-11-26 21:43 PST, Kentaro Hara 		abarth: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 Tuesday, November 27, 2012 3:34:11 AM UTC
Created attachment 176151 [details] Patch
Adam Barth
Comment 2 Tuesday, November 27, 2012 4:42:30 AM UTC
Comment on attachment 176151 [details] Patch Should we remove it from http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt as well?
Kentaro Hara
Comment 3 Tuesday, November 27, 2012 4:47:08 AM UTC
Created attachment 176157 [details] patch for landing
Kentaro Hara
Comment 4 Tuesday, November 27, 2012 4:47:37 AM UTC
Comment on attachment 176157 [details] patch for landing > Should we remove it from http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt as well? Done. Thanks!
WebKit Review Bot
Comment 5 Tuesday, November 27, 2012 5:09:23 AM UTC
Comment on attachment 176157 [details] patch for landing Rejecting attachment 176157 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: TYPE=Release all ACTION Resolving [Supplemental=XXX] dependencies in all IDL files out/Release/obj/gen/supplemental_dependency.tmp IDL ATTRIBUTE CHECKER ERROR: Unknown IDL attribute [SuppressToJSObject] is found at SVGUnitTypes.idl. If you want to add a new IDL attribute, you need to add it to WebCore/bindings/scripts/IDLAttributes.txt and add explanations to the WebKit IDL document (https://trac.webkit.org/wiki/WebKitIDL). make: *** [out/Release/obj/gen/supplemental_dependency.tmp] Error 255 Full output: http://queues.webkit.org/results/14986948
Kentaro Hara
Comment 6 Tuesday, November 27, 2012 5:15:00 AM UTC
oh, SVG idls are using the IDL attribute. Needs more investigations.
Kentaro Hara
Comment 7 Tuesday, November 27, 2012 5:43:57 AM UTC
Created attachment 176167 [details] Patch
Kentaro Hara
Comment 8 Tuesday, November 27, 2012 5:44:26 AM UTC
abarth: review again please ?
Build Bot
Comment 9 Tuesday, November 27, 2012 6:25:07 AM UTC
Comment on attachment 176167 [details] Patch Attachment 176167 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14986964
Adam Barth
Comment 10 Tuesday, November 27, 2012 6:57:32 AM UTC
Comment on attachment 176167 [details] Patch Maybe its useful as an error checking so folks don't call them accidentally? Perhaps the toJS function won't work correctly since these are mixins.
Kentaro Hara
Comment 11 Tuesday, November 27, 2012 7:04:01 AM UTC
(In reply to comment #10) > (From update of attachment 176167 [details]) > Maybe its useful as an error checking so folks don't call them accidentally? Perhaps the toJS function won't work correctly since these are mixins. Ah, makes sense, thanks. Then I'll add the explanation to https://trac.webkit.org/wiki/WebKitIDL . I might want to rename it to [DoNotGeneratorToJSObject] though.
Adam Barth
Comment 12 Tuesday, November 27, 2012 7:09:15 AM UTC
The current name seems fine, but we should add the explanation to the wiki.
Kentaro Hara
Comment 13 Tuesday, November 27, 2012 7:15:58 AM UTC
(In reply to comment #12) > The current name seems fine, but we should add the explanation to the wiki. Done.
Note You need to log in before you can comment on or make changes to this bug.