Bug 103317 - HTML/XML parser helper unconsumeCharacters() can push back 8 bit text as 16 bit text
Summary: HTML/XML parser helper unconsumeCharacters() can push back 8 bit text as 16 b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 16:32 PST by Michael Saboff
Modified: 2012-11-26 19:00 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2012-11-26 16:40 PST, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-11-26 16:32:15 PST
For greater than 2 character push back, unconsumeCharacters() in WebCore/xml/parser/CharacterReferenceParserInlines.h extracts text from the StringBuilder argument as a 16 bit string even if the StringBuilder contains 8 bit text.  Instead, the StringBuilder should be stringified and used directly.
Comment 1 Michael Saboff 2012-11-26 16:40:48 PST
Created attachment 176108 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-26 19:00:47 PST
Comment on attachment 176108 [details]
Patch

Clearing flags on attachment: 176108

Committed r135802: <http://trac.webkit.org/changeset/135802>
Comment 3 WebKit Review Bot 2012-11-26 19:00:50 PST
All reviewed patches have been landed.  Closing bug.