Bug 103312 - [CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
Summary: [CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2012-11-26 15:59 PST by Julien Chaffraix
Modified: 2013-11-27 00:28 PST (History)
16 users (show)

See Also:


Attachments
Patch (17.81 KB, patch)
2013-11-11 09:13 PST, Sergio Villar Senin
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-11-26 15:59:07 PST
The specification allows a grid definition to be repeated by using the repeat() function:

<track-list>    => [ [ <string> ]* <track-group> [ <string> ]* ]+ | none
<track-group>   => <track-minmax> | [ repeat( <positive-integer> , [ [ <string> ]* <track-minmax> [ <string> ]* ]+ ) ]
Comment 1 Sergio Villar Senin 2013-11-11 09:13:54 PST
Created attachment 216577 [details]
Patch
Comment 2 Sergio Villar Senin 2013-11-13 01:25:19 PST
Adding reviewers
Comment 3 Andreas Kling 2013-11-26 10:00:56 PST
Comment on attachment 216577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216577&action=review

r=me

> Source/WebCore/css/CSSParser.cpp:5048
> +            values->append(primitiveValue);

values->append(primitiveValue.release());

> Source/WebCore/css/CSSParser.cpp:5086
> +        repeatedValues->append(trackSize);

repeatedValues->append(trackSize.release());
Comment 4 Sergio Villar Senin 2013-11-27 00:28:47 PST
Committed r159808: <http://trac.webkit.org/changeset/159808>