Bug 103302 - [EFL] Graphics layer edges are sometimes very pixelated
Summary: [EFL] Graphics layer edges are sometimes very pixelated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yael
URL:
Keywords:
Depends on:
Blocks: 103105
  Show dependency treegraph
 
Reported: 2012-11-26 15:06 PST by Yael
Modified: 2012-11-27 06:43 PST (History)
4 users (show)

See Also:


Attachments
The issue (39.04 KB, image/png)
2012-11-26 15:06 PST, Yael
no flags Details
Patch (1.92 KB, patch)
2012-11-26 18:43 PST, Yael
noam: review+
Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2012-11-26 19:09 PST, Yael
noam: review-
noam: commit-queue-
Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2012-11-27 05:06 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2012-11-26 15:06:35 PST
Created attachment 176081 [details]
The issue

The problem can be seen when loading http://trac.webkit.org/export/100000/trunk/LayoutTests/transforms/3d/point-mapping/3d-point-mapping.html.
Reloading a couple of times makes the problem go away.
Comment 1 Kalyan 2012-11-26 17:41:33 PST
(In reply to comment #0)
> Created an attachment (id=176081) [details]
> The issue
> 
> The problem can be seen when loading http://trac.webkit.org/export/100000/trunk/LayoutTests/transforms/3d/point-mapping/3d-point-mapping.html.
> Reloading a couple of times makes the problem go away.

Yes, edges seem to be jagged.

For me Reloading didn't make the problem go away. 

Some other observations:

The edges become smooth after I moved the mouse over the box. When we move the mouse over the box, it results in a coloured border being drawn (I guess some kind of debug borders?? ). Interesting thing is that the edges of coloured border drawn at this point seem to be suffering from the same issue as original box borders.
Comment 2 Yael 2012-11-26 18:03:44 PST
Kalyan volunteered to work on this :)
Comment 3 Yael 2012-11-26 18:24:49 PST
(In reply to comment #2)
> Kalyan volunteered to work on this :)
Taking back, since I found the problem.
Comment 4 Yael 2012-11-26 18:43:17 PST
Created attachment 176142 [details]
Patch
Comment 5 Kalyan 2012-11-26 18:58:48 PST
Do we need to set the flag always??

Shouldn't it be enough to set it during texture creation ??
Comment 6 Yael 2012-11-26 19:01:38 PST
(In reply to comment #5)
> Do we need to set the flag always??
> 
> Shouldn't it be enough to set it during texture creation ??

The flag is set on TextureMapper itself, during its own creation.
Comment 7 Yael 2012-11-26 19:09:55 PST
Created attachment 176149 [details]
Patch

Address comment #5.
Comment 8 Noam Rosenthal 2012-11-26 21:23:16 PST
Comment on attachment 176149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166
>          m_textureMapper = TextureMapper::create();
> +        static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true);

This would crash.
Comment 9 Kenneth Rohde Christiansen 2012-11-27 00:58:06 PST
Comment on attachment 176149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review

>> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166
>> +        static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true);
> 
> This would crash.

Software mode :-)
Comment 10 Yael 2012-11-27 04:58:38 PST
(In reply to comment #9)
> (From update of attachment 176149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review
> 
> >> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166
> >> +        static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true);
> > 
> > This would crash.
> 
> Software mode :-)

oops :)
Comment 11 Yael 2012-11-27 05:06:20 PST
Created attachment 176239 [details]
Patch

Address comment #8.
Comment 12 WebKit Review Bot 2012-11-27 06:43:33 PST
Comment on attachment 176239 [details]
Patch

Clearing flags on attachment: 176239

Committed r135858: <http://trac.webkit.org/changeset/135858>
Comment 13 WebKit Review Bot 2012-11-27 06:43:37 PST
All reviewed patches have been landed.  Closing bug.