Bug 103302 – [EFL] Graphics layer edges are sometimes very pixelated

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Yael]

Created attachment 176081 [details]
The issue

The problem can be seen when loading http://trac.webkit.org/export/100000/trunk/LayoutTests/transforms/3d/point-mapping/3d-point-mapping.html.
Reloading a couple of times makes the problem go away.

[Kalyan]

(In reply to comment #0)
> Created an attachment (id=176081) [details]
> The issue
> 
> The problem can be seen when loading http://trac.webkit.org/export/100000/trunk/LayoutTests/transforms/3d/point-mapping/3d-point-mapping.html.
> Reloading a couple of times makes the problem go away.

Yes, edges seem to be jagged.

For me Reloading didn't make the problem go away. 

Some other observations:

The edges become smooth after I moved the mouse over the box. When we move the mouse over the box, it results in a coloured border being drawn (I guess some kind of debug borders?? ). Interesting thing is that the edges of coloured border drawn at this point seem to be suffering from the same issue as original box borders.

[Yael]

Kalyan volunteered to work on this :)

[Yael]

(In reply to comment #2)
> Kalyan volunteered to work on this :)
Taking back, since I found the problem.

[Yael]

Created attachment 176142 [details]
Patch

[Kalyan]

Do we need to set the flag always??

Shouldn't it be enough to set it during texture creation ??

[Yael]

(In reply to comment #5)
> Do we need to set the flag always??
> 
> Shouldn't it be enough to set it during texture creation ??

The flag is set on TextureMapper itself, during its own creation.

[Yael]

Created attachment 176149 [details]
Patch

Address comment #5.

[Noam Rosenthal]

Comment on attachment 176149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166
>          m_textureMapper = TextureMapper::create();
> +        static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true);

This would crash.

[Kenneth Rohde Christiansen]

Comment on attachment 176149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review

>> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166
>> +        static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true);
> 
> This would crash.

Software mode :-)

[Yael]

(In reply to comment #9)
> (From update of attachment 176149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176149&action=review
> 
> >> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:166
> >> +        static_cast<TextureMapperGL*>(m_textureMapper.get())->setEnableEdgeDistanceAntialiasing(true);
> > 
> > This would crash.
> 
> Software mode :-)

oops :)

[Yael]

Created attachment 176239 [details]
Patch

Address comment #8.

[WebKit Review Bot]

Comment on attachment 176239 [details]
Patch

Clearing flags on attachment: 176239

Committed r135858: <http://trac.webkit.org/changeset/135858>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.